Library/base64#648
Merged
Merged
Conversation
mattwang44
reviewed
Sep 9, 2023
mattwang44
left a comment
mattwang44
left a comment
Collaborator
There was a problem hiding this comment.
review part 1
有用到不少簡中慣用用法，再麻煩幫忙修正：
- interface: 接口 -> 介面
- string: 字符串 -> 字串
- return: 返回 -> 回傳
- mapping: 映射 -> 對映
- binary/hex: xx進制 -> xx進位
- support: 支持 -> 支援
- object: 對象 -> 物件
- file: 文件 -> 檔案
- Internet: 互聯網 -> 網際網路
下個階段再 review 翻譯正確性與暢通性
Contributor
Author
|
Got it! |
ken71301
reviewed
Sep 20, 2023
ken71301
reviewed
Sep 20, 2023
ken71301
reviewed
Sep 20, 2023
ken71301
reviewed
Sep 20, 2023
ken71301
reviewed
Sep 20, 2023
ken71301
reviewed
Sep 20, 2023
ken71301
reviewed
Sep 20, 2023
ken71301
reviewed
Sep 20, 2023
ken71301
reviewed
Sep 20, 2023
ken71301
reviewed
Sep 20, 2023
ken71301
reviewed
Sep 20, 2023
ken71301
reviewed
Sep 20, 2023
ken71301
reviewed
Sep 20, 2023
ken71301
reviewed
Sep 20, 2023
Contributor
Author
|
Thanks! |
Collaborator
|
嗨 @Yang92047111 |
Contributor
Author
|
不好意思，這週會把它完成！ |
Collaborator
|
@ken71301 想麻煩你繼續 review 這個 PR，感謝 🙏🏽 |
Collaborator
|
ok~ |
ken71301
reviewed
Nov 14, 2023
Collaborator
|
嗨 @Yang92047111 |
Contributor
Author
|
不好意思，這週會Push一版！ |
ken71301
reviewed
Dec 24, 2023
ken71301
left a comment
ken71301
left a comment
Collaborator
There was a problem hiding this comment.
review part 4,
Still loads of stuff should be fix, many of them were mentioned in previous reviews already, ty.
mattwang44
reviewed
Jan 3, 2024
Collaborator
There was a problem hiding this comment.
@Yang92047111
想請你先修正以下問題，要麻煩你檢查 PR 所有出現的地方（review comment 可能只會註明一處，不會全部指出）：
- 修正字詞翻譯
- flag -> 旗標
- bytes -> 翻成「位元組」而非「字節」
- optional -> 可選的
- character -> 翻成「字元」而非「字符」
- implementation -> 統一翻成「實作」，目前還是有錯譯的地方
- security purposes -> 宜譯作「安全性考量」
- 請記得留空格的規則：
- 全形標點符號與中文字、英文字母、羅馬數字間皆不需要留空格
- 中文字與英文字母、數字間需要留空格
- 目前使用雙斜線的時機，大多不必要或者錯誤，請先麻煩你讀懂這篇說明後進行修正
- nit: PO 檔案的慣例是會為了更好的閱讀性而斷行，但斷行位置不會是讓編輯者自行花時間判斷，請使用 pogrep 這項工具來幫助你做格式化（請參考這份文件）
mattwang44
reviewed
Jan 15, 2024
mattwang44
left a comment
mattwang44
left a comment
Collaborator
There was a problem hiding this comment.
nice work! almost there
mattwang44
reviewed
Apr 26, 2024
mattwang44
left a comment
mattwang44
left a comment
Collaborator
There was a problem hiding this comment.
抱歉擱置過久
我覺得目前翻譯已經夠好了，我補上幾個小 patch 後就 merge 🙏🏽
mattwang44
force-pushed
the
library/base64
branch
from
e7b3e08 to
b57c78b
Compare
mattwang44
approved these changes
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.