Skip to content

Translate wav.po#797

Merged
rockleona merged 11 commits into
python:3.12from
Mayavi345:translate-wav
Feb 15, 2024
Merged

Translate wav.po#797
rockleona merged 11 commits into
python:3.12from
Mayavi345:translate-wav

Conversation

@Mayavi345

Copy link
Copy Markdown
Contributor

No description provided.

@mattwang44 mattwang44 requested a review from rockleona January 8, 2024 02:16

@rockleona rockleona left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Part 1,晚點繼續接力 Review

抓了簡短的時間 Review 一下,目前翻譯上都沒什麼大問題,
還要花點時間習慣一下這邊的語法編輯習慣喔

Comment thread library/wave.po Outdated
Comment thread library/wave.po Outdated
Comment thread library/wave.po Outdated

@rockleona rockleona left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finish Review

Comment thread library/wave.po Outdated
Comment thread library/wave.po Outdated
Comment thread library/wave.po Outdated
Comment thread library/wave.po Outdated
Comment thread library/wave.po Outdated
Comment thread library/wave.po Outdated
Comment thread library/wave.po Outdated
Comment thread library/wave.po Outdated
Comment thread library/wave.po Outdated
Comment thread library/wave.po Outdated
@Mayavi345 Mayavi345 closed this Jan 27, 2024
@Mayavi345 Mayavi345 deleted the translate-wav branch January 27, 2024 06:55
@mattwang44

Copy link
Copy Markdown
Collaborator

@Mayavi345 為何要關 PR 呢?

@Mayavi345

Mayavi345 commented Jan 27, 2024

Copy link
Copy Markdown
Contributor Author

@mattwang44
我以為合併回去了,我就把分支刪掉了。
我恢復,並重新開啟了
謝謝提醒

@Mayavi345 Mayavi345 restored the translate-wav branch January 27, 2024 08:14
@Mayavi345 Mayavi345 reopened this Jan 27, 2024
@mattwang44

mattwang44 commented Jan 27, 2024

Copy link
Copy Markdown
Collaborator

@Mayavi345 ok~ 沒關係的,再麻煩你記得把修正的 commits 推上來 🙏🏽
(我看有部分 comment 已經被你 resolve 但沒看到修正?)

Mayavi345 and others added 7 commits February 3, 2024 16:42
Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com>
Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com>
Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com>
Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com>
Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com>
Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com>
@Mayavi345

Copy link
Copy Markdown
Contributor Author

@mattwang44 目前看起來應該是都完成了,謝謝提醒!

@rockleona

Copy link
Copy Markdown
Collaborator

@Mayavi345 我把沒有修正到的地方都重新打開了,你再看看

如果有任何問題的地方可以問我或是 Matt 都可以喔

Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com>
@Mayavi345

Copy link
Copy Markdown
Contributor Author

@rockleona OK 我加入到分支中了,修整完畢

@rockleona rockleona left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 感謝 @Mayavi345

@rockleona rockleona merged commit a7734ef into python:3.12 Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants