Skip to content

Translate license.po#94

Merged
mattwang44 merged 7 commits into
python:3.9from
StevenHsuYL:license
Oct 19, 2021
Merged

Translate license.po#94
mattwang44 merged 7 commits into
python:3.9from
StevenHsuYL:license

Conversation

@StevenHsuYL

Copy link
Copy Markdown
Contributor

Complete translation of license.po
Thanks for review.

Reference: https://terms.naer.edu.tw/

Complete translation of license.po
Fix a rST problem.
Fix the term "副本".
@StevenHsuYL StevenHsuYL mentioned this pull request Jul 7, 2021
@mattwang44 mattwang44 mentioned this pull request Oct 8, 2021
Comment thread license.po Outdated
Comment thread license.po Outdated
Comment thread license.po Outdated
Comment thread license.po Outdated
Comment thread license.po Outdated
@mattwang44

mattwang44 commented Oct 17, 2021

Copy link
Copy Markdown
Collaborator

@StevenHsuYL I noticed that several new source strings are added after this PR is opened. Would you mind also translating them?

Apply all suggestions.

Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
@StevenHsuYL

StevenHsuYL commented Oct 19, 2021

Copy link
Copy Markdown
Contributor Author

noticed that several new source strings are added after this PR is opened. Would you mind also translating them?

Of course not! Could you point out the newly added source strings?
BTW, I have also updated the "masOS" term here, which was updated in cpython on Sep, 23 by GH-28515.

@mattwang44

Copy link
Copy Markdown
Collaborator

Of course! Could you point out the newly added source strings?

You can refer to this link for the untranslated source strings in license.po.

BTW, I have also updated the "masOS" term here, which was updated on Sep, 23 by GH-28515.

Yeah I've noticed that you discover the modification in CPython and made the change in advance! That's pretty nice! I just want to mention that we have a GitHub Action workflow checks if any string in CPython is modified and sends a PR if so (such as this PR also handles the changes of macOS terms). So we probably do not need to spend effort on checking CPython doc from now on!

@StevenHsuYL

Copy link
Copy Markdown
Contributor Author

Of course! Could you point out the newly added source strings?

You can refer to this link for the untranslated source strings in license.po.

I did. I found these three "untranslated" sentences had already been translated in the above codes,
Therefore, they're "redundant" source strings.

BTW, I have also updated the "masOS" term here, which was updated on Sep, 23 by GH-28515.

Yeah I've noticed that you discover the modification in CPython and made the change in advance! That's pretty nice! I just want to mention that we have a GitHub Action workflow checks if any string in CPython is modified and sends a PR if so (such as this PR also handles the changes of macOS terms). So we probably do not need to spend effort on checking CPython doc from now on!

Great! It's excellent that we can sync with CPython automatically!

@mattwang44

Copy link
Copy Markdown
Collaborator

aw, i got it!
I'll take those string down if needed. Thanks again for your effort!

@mattwang44 mattwang44 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattwang44 mattwang44 merged commit a8ffd10 into python:3.9 Oct 19, 2021
@StevenHsuYL StevenHsuYL deleted the license branch October 27, 2021 01:44
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants