Skip to content

🚜 Improve the news links in the header menu and on the homepage - #3092

Open
jefftriplett wants to merge 12 commits into
mainfrom
blogs-latest-news-links
Open

🚜 Improve the news links in the header menu and on the homepage#3092
jefftriplett wants to merge 12 commits into
mainfrom
blogs-latest-news-links

Conversation

@jefftriplett

@jefftriplett jefftriplett commented Aug 14, 2026

Copy link
Copy Markdown
Member

The Latest News section on python.org aggregates posts from several different sources, but its “More” link currently sends people to the newer blog.python.org site. That is confusing because not all of the news shown on python.org appears there. In particular, PSF announcements, election information, and other posts published through the PSF blog can be easy to miss unless someone already knows to visit pyfound.blogspot.com.

This PR makes the News section and menu a little clearer:

  • Changes the homepage “More” link to point to /blogs/, the existing python.org page that aggregates these sources.
  • Expands /blogs/ from 6 entries to 15. The newest entry is used as the page header, with the other 14 shown in the list.
  • Restyles the /blogs/ list to match the homepage Latest News widget: the date sits in its own column next to the title, instead of leaving a large empty gap with the title and date pushed into a second column.
  • Drops the “More” link from /blogs/ itself. That page already aggregates every source, so there was no single “more” to point at. A News Sources widget in the right column, below Python Insider Subscriptions, now links to each site instead: Python Insider, the PSF Blog, the PyCon Blog, and Planet Python.

The homepage Latest News widget itself still shows 5 entries; only its link destination changes.

This PR no longer touches the fixtures. The News menu updates (the Python Insider item, the wording, the HTTPS links, and hiding the Python Brochure entry) and the blogs-copyright box are applied directly to the live rows in the admin, since fixtures are seed data and do not update existing databases.

Copilot AI lite review requested due to automatic review settings August 14, 2026 00:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the homepage “Latest News” More link destination with the site’s aggregated news feed by pointing it to the local /blogs/ page, and increases the number of entries shown on that /blogs/ page.

Changes:

  • Update the homepage “More” link to use the internal blog URL instead of BLOG_URL.
  • Increase /blogs/ page entry list size from 5 to 10 (by fetching ENTRY_LIST_LIMIT + 1 to support a featured header entry).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
templates/components/blog-posts.html Updates “More” to reverse the internal blog URL.
apps/blogs/views.py Adds ENTRY_LIST_LIMIT = 10 and expands the BlogHome queryset slice accordingly.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread apps/blogs/views.py Outdated
Copilot AI review requested due to automatic review settings August 14, 2026 00:59
@jefftriplett jefftriplett changed the title Show 10 news entries on /blogs/ and point the homepage More link there Improve the news links in the header menu and on the homepage Aug 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (3)

apps/blogs/views.py:21

  • There is an extra space after the slice colon ([: ENTRY_LIST_LIMIT + 1]). This is inconsistent with typical formatting and may trigger linting (e.g., flake8 E203) depending on project config.
        entries = BlogEntry.objects.order_by("-pub_date")[: ENTRY_LIST_LIMIT + 1]

apps/blogs/views.py:22

  • The view behavior change increases the number of blog entries surfaced on the blog homepage (from 6 total to ENTRY_LIST_LIMIT + 1). The existing view test asserts the latest entry but doesn’t assert how many entries are exposed in resp.context["entries"], so this change isn’t guarded against regressions.
    def get_context_data(self, **kwargs):
        """Return the latest blog entries for the blog homepage."""
        context = super().get_context_data(**kwargs)

        entries = BlogEntry.objects.order_by("-pub_date")[: ENTRY_LIST_LIMIT + 1]
        latest_entry = None

templates/components/blog-posts.html:8

  • The homepage "Latest News" component is still fetching only 5 entries (limit=5), but the PR description says this section should show 10. This currently doesn’t implement the intended behavior.
                                {% get_latest_blog_entries limit=5 as entries %}

Copilot AI review requested due to automatic review settings August 14, 2026 01:02
@jefftriplett jefftriplett changed the title Improve the news links in the header menu and on the homepage 🚜 Improve the news links in the header menu and on the homepage Aug 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (1)

fixtures/boxes.json:467

  • This fixture still links to Python Insider over plain HTTP (http://blog.python.org). Since this PR is explicitly moving external links to HTTPS, this should also be updated to avoid mixed/insecure links.
      "content": "<h2 class=\"widget-title\">Copyright</h2>\r\n<p>Python Insider by the Python core team is licensed under a <a href=\"https://creativecommons.org/licenses/by-nc-sa/3.0/us/\">Creative Commons Attribution-NonCommercial-ShareAlike 3.0 Unported License</a>. Based on a work at <a href=\"http://blog.python.org\">blog.python.org</a>.</p>",
      "content_markup_type": "html",
      "_content_rendered": "<h2 class=\"widget-title\">Copyright</h2>\r\n<p>Python Insider by the Python core team is licensed under a <a href=\"https://creativecommons.org/licenses/by-nc-sa/3.0/us/\">Creative Commons Attribution-NonCommercial-ShareAlike 3.0 Unported License</a>. Based on a work at <a href=\"http://blog.python.org\">blog.python.org</a>.</p>"

Copilot AI review requested due to automatic review settings August 14, 2026 01:04
@jefftriplett
jefftriplett force-pushed the blogs-latest-news-links branch from 0b37d16 to 8b28a1f Compare August 14, 2026 01:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (2)

fixtures/boxes.json:467

  • The updated blogs copyright box still links to http://blog.python.org, even though the project’s configured blog URL is HTTPS and this PR is moving external links to HTTPS. Update the link to https://blog.python.org in both content and _content_rendered.
      "content": "<h2 class=\"widget-title\">Copyright</h2>\r\n<p>Python Insider by the Python core team is licensed under a <a href=\"https://creativecommons.org/licenses/by-nc-sa/3.0/us/\">Creative Commons Attribution-NonCommercial-ShareAlike 3.0 Unported License</a>. Based on a work at <a href=\"http://blog.python.org\">blog.python.org</a>.</p>",
      "content_markup_type": "html",
      "_content_rendered": "<h2 class=\"widget-title\">Copyright</h2>\r\n<p>Python Insider by the Python core team is licensed under a <a href=\"https://creativecommons.org/licenses/by-nc-sa/3.0/us/\">Creative Commons Attribution-NonCommercial-ShareAlike 3.0 Unported License</a>. Based on a work at <a href=\"http://blog.python.org\">blog.python.org</a>.</p>"

apps/blogs/views.py:9

  • ENTRY_LIST_LIMIT = 10 currently results in only 9 items in the “Latest News” list on /blogs/ because the newest entry is moved into the page header (other_entries = entries[1:]). If the intent is to show 10 list items (as before: query size = list size + 1), fetch one extra entry and slice using a dedicated query-limit constant.
# Number of entries the page shows. The newest one goes in the page
# header, the rest go in the "Latest News" list.
ENTRY_LIST_LIMIT = 10

Copilot AI review requested due to automatic review settings August 14, 2026 01:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (2)

templates/components/blog-posts.html:8

  • PR description says the homepage widget should show 10 news entries instead of 5, but this template tag still limits the list to 5.
                                {% get_latest_blog_entries limit=5 as entries %}

apps/blogs/views.py:21

  • ENTRY_LIST_LIMIT = 10 currently results in 9 items in the "Latest News" list because the template treats the first entry as the separate header item (other_entries = entries[1:]). If the intent is 10 list items (i.e., matching the prior behavior where [:6] produced 5 list items), the query needs to fetch one extra entry; otherwise, consider updating the constant/docstring/PR description to make it explicit that 10 is the total (1 header + 9 list).
        entries = BlogEntry.objects.order_by("-pub_date")[:ENTRY_LIST_LIMIT]

Copilot AI review requested due to automatic review settings August 14, 2026 01:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

@jefftriplett
jefftriplett force-pushed the blogs-latest-news-links branch from 5a7ce27 to 4a79a1e Compare August 18, 2026 20:14
Copilot AI review requested due to automatic review settings August 18, 2026 20:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Suppressed comments (1)

apps/blogs/views.py:9

  • ENTRY_LIST_LIMIT is described/used as the total number of entries shown on the page (header entry + list items), but the name reads like it only limits the list portion. Renaming to something like ENTRY_PAGE_LIMIT/BLOG_HOME_ENTRY_COUNT would make the intent clearer and avoid off-by-one confusion when using ENTRY_LIST_LIMIT - 1 for the list size in tests.
# Number of entries the page shows. The newest one goes in the page
# header, the rest go in the "Latest News" list.
ENTRY_LIST_LIMIT = 10

hugovk
hugovk previously approved these changes Sep 2, 2026

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice improvement.

  • Clarifies the Python News menu wording so it is clearer that it points to the aggregated /blogs/ page rather than directly to Python Insider.

Where's this one? I didn't spot it.

Comment thread apps/blogs/tests/test_views.py Outdated
Comment thread apps/blogs/tests/test_views.py Outdated
Copilot AI review requested due to automatic review settings September 2, 2026 12:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Two moderate issues remain unresolved: responsive widget stacking and updating existing box data.

Review details

Suppressed comments (2)

Previously missed (1) — in code that hasn't changed since the last review.

fixtures/boxes.json:465

  • This boxes.json edit only changes seed data: BoxFactory uses django_get_or_create = ("label",) and initial_data() passes the existing row through without updating its content (apps/boxes/factories.py:17-40). Therefore an existing deployment will keep the old blogs-copyright text and http://blog.python.org link, so this HTTPS/wording change will not appear there. Please update the existing Box in a data migration or deployment step as well.

apps/blogs/templates/blogs/index.html:42

  • At the 800–940px breakpoint, .small-widget is 48.9% wide and .last only removes the right margin, so this new widget can sit beside blogs-subscriptions instead of below it; on wider screens the following copyright widget can also float beside it. Add a clear/stacking rule or wrapper so the right-column widgets remain vertical at these responsive widths.
                    <div class="small-widget news-sources-widget last">
  • Files reviewed: 7/7 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@jefftriplett

Copy link
Copy Markdown
Member Author

Thanks, nice improvement.

  • Clarifies the Python News menu wording so it is clearer that it points to the aggregated /blogs/ page rather than directly to Python Insider.

Where's this one? I didn't spot it.

Sorry, that was a little confusing. I made some changes in the fixtures then realized some of it I could already fix (like https) in the live website.

jefftriplett and others added 9 commits September 11, 2026 15:52
Add a Python Insider link to the News menu, point the homepage More
link at /blogs/ instead of the external blog, and show 10 entries
there instead of 6.

Also switch the external nav links to https and clarify the Python
News wording, since that item goes to /blogs/ and not to Python
Insider.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 11, 2026 20:53
@jefftriplett
jefftriplett force-pushed the blogs-latest-news-links branch from 8b46495 to 9f15f2f Compare September 11, 2026 20:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The deployed blogs-copyright Box still retains the old copyright text and HTTP link because fixture changes do not update existing rows.

Get a fresh assessment by requesting another Copilot review.

Review details
  • Files reviewed: 7/7 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread fixtures/boxes.json Outdated
Copilot AI review requested due to automatic review settings September 12, 2026 00:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Fix the medium-width News Sources layout and ensure the HTTPS box URL updates existing data.

Review details

Suppressed comments (2)

Previously missed (1) — in code that hasn't changed since the last review.

apps/blogs/templates/blogs/index.html:42

  • At the 50–58.75em breakpoint, .small-widget is 48.9% wide and .last only removes the right margin; it does not float the widget right or clear the preceding float. Since the subscription is the second child and this new widget is the third, they render side by side rather than with News Sources below the subscription, contrary to the stated layout. Add a responsive clear/stacking rule for this widget (and verify the medium-width layout).

fixtures/boxes.json:467

  • This fixture edit will not update an existing blogs-copyright row: apps/boxes/factories.initial_data() passes the fields to a BoxFactory configured with django_get_or_create=("label",), so an existing production box keeps the old http://blog.python.org link. Unlike the sitetree items (which the PR says were updated separately), this change needs a corresponding Box update/data migration if the HTTPS switch is meant to affect deployed pages.
      "content": "<h2 class=\"widget-title\">Copyright</h2>\r\n<p>Python Insider by the Python Core Developers is licensed under a <a href=\"https://creativecommons.org/licenses/by-nc-sa/3.0/us/\">Creative Commons Attribution-NonCommercial-ShareAlike 3.0 Unported License</a>. Based on a work at <a href=\"https://blog.python.org\">blog.python.org</a>.</p>",
      "content_markup_type": "html",
      "_content_rendered": "<h2 class=\"widget-title\">Copyright</h2>\r\n<p>Python Insider by the Python Core Developers is licensed under a <a href=\"https://creativecommons.org/licenses/by-nc-sa/3.0/us/\">Creative Commons Attribution-NonCommercial-ShareAlike 3.0 Unported License</a>. Based on a work at <a href=\"https://blog.python.org\">blog.python.org</a>.</p>"
  • Files reviewed: 7/7 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Copilot AI review requested due to automatic review settings September 12, 2026 00:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Add a homepage/template regression assertion for the updated news link.

Review details

Suppressed comments (1)

templates/components/blog-posts.html:5

  • This changes the only homepage news-link behavior, but the added tests cover only /blogs/; the homepage view tests do not assert the rendered href. A regression back to BLOG_URL (or another destination) would therefore pass unnoticed. Please add a homepage/template regression assertion for this link.
                            <p class="give-me-more"><a href="{% url 'blog' %}">More news</a></p>
  • Files reviewed: 5/5 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Copilot AI review requested due to automatic review settings September 12, 2026 00:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The reviewed changes have no unresolved blocking issues.

Review details
  • Files reviewed: 5/5 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@jefftriplett
jefftriplett requested a review from hugovk September 12, 2026 00:46

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip: No need to force push to keep a clean commit history, because most repos in the python org squash-merge everything to a single commit. And force push makes it harder to re-review incremental updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants