Skip to content

Make HTTPError instantiable. #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
carljm wants to merge 3 commits into from
Closed

Make HTTPError instantiable. #1379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94592d4
Make HTTPError instantiable by introducing fictional _ConcreteBinaryI…
carljm Jun 1, 2017
14a0c0e
Fix obsolete TODO regarding TracebackType.
carljm Jun 1, 2017
9848b6b
Use BufferedRandom instead of _ConcreteBinaryIO.
carljm Jun 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions stdlib/3/typing.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,8 +387,7 @@ class IO(Iterator[AnyStr], Generic[AnyStr]):
def __enter__(self) -> 'IO[AnyStr]': ...
@abstractmethod
def __exit__(self, t: Optional[Type[BaseException]], value: Optional[BaseException],
# TODO: traceback should be TracebackType but that's defined in types
traceback: Optional[Any]) -> bool: ...
traceback: Optional[TracebackType]) -> bool: ...

class BinaryIO(IO[bytes]):
# TODO readinto
Expand Down
5 changes: 3 additions & 2 deletions stdlib/3/urllib/response.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
# private module, we only expose what's needed

from typing import BinaryIO, Mapping, Optional
from io import BufferedRandom
from typing import Mapping, Optional
from types import TracebackType

class addinfourl(BinaryIO):
class addinfourl(BufferedRandom):
headers = ... # type: Mapping[str, str]
url = ... # type: str
code = ... # type: int
Expand Down