Add typing to unittest.mock._patch_dict.__call__ - #16310
Open
mxr wants to merge 2 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Aug 28, 2026
Member
|
I dug through the blame a bit to see if there had been any previous churn or discussion about this signature, since annotations in |
Member
|
This LGTM other than the simplification I suggested above, it does seem like this preserves the wrapped function's signature. Thanks! |
_F's bound (Callable[..., Any]) already covers the class and async cases, and generic solving binds to the actual argument type rather than the bound, so the separate _TT/_AF overloads were redundant.
mxr
changed the title
unittest.mock._patch_dict.__call__unittest.mock._patch_dict.__call__
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #16307