NXP backend: Add format checks to prevent NodeFormatInference bugs.#20333
Open
MartinPavella wants to merge 2 commits into
Open
Conversation
MartinPavella
added
module: nxp
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20333
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 6c32d50 with merge base 6021a58 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
|
Collaborator
Author
|
@novak-vaclav please feel free to have a look. |
MartinPavella
force-pushed
the
nxg01483/EIEX-913-create-format-asserting-method-in-nodeconverter
branch
from
b137126 to
17c6490
Compare
JakeStevens
reviewed
Jun 23, 2026
JakeStevens
reviewed
Jun 23, 2026
novak-vaclav
left a comment
novak-vaclav
left a comment
Collaborator
There was a problem hiding this comment.
I have a few minor comments, otherwise very good 👍
| assert not graph_contains_any_of_ops(ep.graph, [ExecutorchDelegateCall]) | ||
|
|
||
| # Make sure the warning is printed. | ||
| assert any( |
MartinPavella
force-pushed
the
nxg01483/EIEX-913-create-format-asserting-method-in-nodeconverter
branch
from
17c6490 to
6c32d50
Compare
novak-vaclav
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add format checks to prevent NodeFormatInference bugs. In the past we have had PRs which introduced new ops but failed to update the format inference. The decorator introduced in this PR should reduce the likelihood of it happening again.
Test plan
Unit tests provided.
cc @robert-kalmar @JakeStevens @digantdesai @rascani