Add CUDA 13.2 support and drop unsupported 12.8/12.9#20440
Merged
Conversation
Add (13, 2) to SUPPORTED_CUDA_VERSIONS in install_utils.py and to the cuda.yml build matrix. Remove 12.8 and 12.9, which are no longer supported.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20440
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
mergennachin
approved these changes
Jun 24, 2026
Gasoonjia
added a commit
that referenced
this pull request
Jun 26, 2026
…failure The Windows CI image ships CUDA toolkits on PATH. After adding (13, 2) to SUPPORTED_CUDA_VERSIONS (#20440), install_executorch's auto-detection (setup.py: is_cuda_available() via nvcc) started returning True on the Windows runner (which has the CUDA 13.2 toolkit), so it flipped EXECUTORCH_BUILD_CUDA=ON. But the unittest jobs install CPU torch, so the resulting CUDA build of _portable_lib fails to load its CUDA DLLs at import time: ImportError: DLL load failed while importing _portable_lib causing all pytest collection to error out (unittest / unittest-editable / unittest-release on windows). Add a -cpuOnly switch to setup-windows.ps1 that forces -DEXECUTORCH_BUILD_CUDA=OFF via CMAKE_ARGS, and pass it from the CPU unittest workflow. The CUDA Windows jobs (cuda-windows.yml) keep the default and are unaffected.
Gasoonjia
added a commit
that referenced
this pull request
Jun 26, 2026
…LL load failure Same root cause as the unittest fix in this PR, second site. The Windows wheel build (build-wheels-windows.yml -> .ci/scripts/wheel/) does not go through setup-windows.ps1. The Windows CI image has the CUDA 13.2 toolkit on PATH, so after #20440 added (13, 2) to SUPPORTED_CUDA_VERSIONS, install_executorch's auto-detection enables EXECUTORCH_BUILD_CUDA and bakes a CUDA _portable_lib + aoti_cuda_shims.lib into the CPU wheel. The smoke test then fails with: ImportError: DLL load failed while importing _portable_lib Windows wheels are CPU-only (with-cuda: disabled), so force -DEXECUTORCH_BUILD_CUDA=OFF via CMAKE_ARGS in pre_build_script.sh on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add (13, 2) to SUPPORTED_CUDA_VERSIONS in install_utils.py and to the cuda.yml build matrix. Remove 12.8 and 12.9, which are no longer supported.