Skip to content

Issue/197 php 8 baseline#198

Open
armanist wants to merge 2 commits into
quantum-php:masterfrom
armanist:issue/197-php-8-baseline
Open

Issue/197 php 8 baseline#198
armanist wants to merge 2 commits into
quantum-php:masterfrom
armanist:issue/197-php-8-baseline

Conversation

@armanist

Copy link
Copy Markdown
Contributor

Closes #197

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 319027bad8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread composer.json
"php": "^7.4 || ^8.0",
"quantum/framework": "^3.0.0",
"php": "^8.0",
"quantum/framework": "dev-master",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Pin framework dependency to a stable release

For fresh installs or CI runs that resolve dependencies without a lock file, this now pulls quantum/framework from whatever is on master at install time instead of the released 3.x series. A tagged quantum/project release could therefore pick up unreleased or breaking framework changes unrelated to this PHP-baseline update, whereas the previous ^3.0.0 constraint kept projects on stable releases.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prepare Quantum Project for PHP 8 baseline alignment

1 participant