Skip to content

Asciidoc floatreftarget fixes#8087

Merged
cscheid merged 2 commits into
mainfrom
bugfix/8055
Jan 3, 2024
Merged

Asciidoc floatreftarget fixes#8087
cscheid merged 2 commits into
mainfrom
bugfix/8055

Conversation

@cscheid

@cscheid cscheid commented Jan 2, 2024

Copy link
Copy Markdown
Member

Closes #8055.

I'm not confident that we're generating the correct output here, but given the reported .qmd, our output in this branch is:

= Caption

<<tbl-fruit>> shows just how expensive fruit is these days.

[[tbl-fruit]]
.Various fruits and their prices
[cols=",>",options="header",]
|===
|fruit |price
|apple |2.05
|pear |1.37
|orange |3.09
|===

And if that’s not convincing, consider <<fig-fruit>>.

.Pretty convincing
[#fig-fruit]
image::8055_files/figure-asciidoc/mermaid-figure-1.png[Pretty convincing,width=550,height=133]

Fin.

@cscheid cscheid requested a review from cderv January 2, 2024 18:16

@cderv cderv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! Interesting to understand more about floatreftarget.

We probably need to more test case about what float.content - see my comment about the subfigures issues.

Comment thread src/resources/filters/customnodes/floatreftarget.lua Outdated
Comment thread src/resources/filters/customnodes/floatreftarget.lua Outdated
Comment thread src/resources/filters/customnodes/floatreftarget.lua Outdated
@cscheid cscheid merged commit 746aae0 into main Jan 3, 2024
@cscheid cscheid deleted the bugfix/8055 branch January 3, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table and figure captions not working in AsciiDoc

2 participants