Add DynamicQualifier setting to enable duplicate dynamic sessions - #393
Merged
Conversation
added 2 commits
January 3, 2020 16:08
Author
reddec
approved these changes
Jan 4, 2020
reddec
left a comment
reddec
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! Can test it at Monday, but feels like should not have any negative impact.
Author
Contributor
|
🤘 sorry for the delay, thanks for the contribution! |
level2player
pushed a commit
to longbridge/quickfix
that referenced
this pull request
Jul 19, 2022
Add DynamicQualifier setting to enable duplicate dynamic sessions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using the
DynamicSessionssetting, but I'd like to allow users to connect multiple times using the same SenderCompID.Right now, that's not possible because the Acceptor generates the SessionID without a Qualifier. I've added a new setting, such that when
DynamicQualifier=Y, it will automatically add a distinct qualifier to dynamic session IDs.