Stop workers when job finalization fails - #768
Open
rafael-pissardo wants to merge 7 commits into
Open
Conversation
rafael-pissardo
force-pushed
the
fix/748-claimed-execution-stuck-on-finished-failure
branch
from
July 24, 2026 20:03
249f2ec to
db4a139
Compare
Prevent claimed executions from remaining stuck after transient database errors by terminating the owning worker so shutdown releases the claim.
rafael-pissardo
force-pushed
the
fix/748-claimed-execution-stuck-on-finished-failure
branch
from
July 24, 2026 20:03
db4a139 to
d903a36
Compare
…failure Adapt FinalizationError worker shutdown to the new Pool / ThreadPool / FiberPool hierarchy while preserving claim release on finalization failure. Co-authored-by: Cursor <cursoragent@cursor.com>
Align instrumentation and FiberPool builder specs with current API after merging main (on_unrecoverable_error) and FinalizationError wrapping. Co-authored-by: Cursor <cursoragent@cursor.com>
Execute-phase errors should propagate unchanged to thread_error instrumentation. Reserve FinalizationError for failures while the claim is still held after finished/failed_with, and align the worker spec with a real finalization failure stub. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Count only FinalizationError entries so incidental duplicate error reports from the execution wrapper do not fail the spec on CI. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #748.
Test plan
TARGET_DB=sqlite bundle exec ruby -Itest test/unit/worker_test.rbTARGET_DB=sqlite bundle exec ruby -Itest test/models/solid_queue/claimed_execution_test.rbTARGET_DB=sqlite bundle exec ruby -Itest test/integration/jobs_lifecycle_test.rb