chore: add php 8.5 to tests

.github/workflows/test.yml

@@ -8,12 +8,13 @@ concurrency:
   cancel-in-progress: true
 
 on:
-  push:
-    paths-ignore:
-      - '**.md'
   pull_request:
     paths-ignore:
       - '**.md'
+    types:
+      - opened
+      - synchronize
+      - reopened
 
 jobs:
   test:
@@ -26,6 +27,7 @@ jobs:
           - ubuntu-latest
         php-version:
           - '8.4'
+          - '8.5'
 
     steps:
       - name: Checkout
@@ -55,12 +57,13 @@ jobs:
         run: composer install --prefer-dist --no-progress
 
       - name: Lint
+        if: matrix.php-version == '8.4'
         run: |
-          PHP_CS_FIXER_IGNORE_ENV=True vendor/bin/php-cs-fixer fix --diff --dry-run
+          vendor/bin/php-cs-fixer fix --diff --dry-run
 
       - name: PHPUnit
         run: |
-          vendor/bin/phpunit --colors --coverage-text --coverage-clover coverage/clover.xml
+          vendor/bin/phpunit --colors --display-all-issues --coverage-text --coverage-clover coverage/clover.xml
 
       - name: Upload coverage
         uses: codecov/codecov-action@v6

composer.json

@@ -37,7 +37,7 @@
             "php-cs-fixer fix -vvv"
         ],
         "test": [
-            "phpunit --colors --coverage-html ./coverage"
+            "phpunit --colors --display-all-issues --coverage-html ./coverage"
         ]
     }
 }

src/Security.php

@@ -156,7 +156,12 @@ public static function escAttr(mixed $text, string $charset = 'UTF-8'): string
 
         $text = \preg_replace_callback('/[^a-z0-9,.\-_]/iSu', static function ($matches) {
             $chr = $matches[0];
-            $ord = \ord($chr);
+
+            if (\strlen($chr) === 1) {
+                $ord = \ord($chr);
+            } else {
+                $ord = \mb_ord($chr, 'UTF-8');
+            }
 
             if (($ord <= 0x1F && $chr !== "\t" && $chr !== "\n" && $chr !== "\r")
                 || ($ord >= 0x7F && $ord <= 0x9F)

tests/SecurityTest.php

@@ -426,7 +426,7 @@ public function testCharsetNotSupportedException(): void
 
     public function testInvalidCharacter(): void
     {
-        $invalidChar = \chr(99999999);
+        $invalidChar = "\xFF";
         $countThrownExceptions = 0;
 
         try {