PR #22d: strip redundant test-file nolints → zero nolint:errcheck tree-wide#33
Merged
Conversation
errcheck is excluded for *_test.go in .golangci*.yml, so the ~115 //nolint:errcheck directives in test files were pure noise — strip them all (the explicit '_ =' discards stay; they're fine with errcheck off in tests). Also reword pkg/xsync/pool.go's package doc so it no longer quotes the literal directive. After this, 'grep -rn nolint:errcheck' over non-vendor .go returns nothing tree-wide. Both golangci-lint tiers pass; full suite green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #22d — strip the last redundant
//nolint:errcheck(the finale of the #22 cleanup).errcheckis excluded for_test.goin.golangci.yml/.golangci-comprehensive.yml(path: "_test\.go"→errcheck), so the ~115//nolint:errcheckdirectives scattered across 18 test files were pure noise — they suppressed a linter that never runs there. Stripped them all (the explicit_ =discards stay; they're fine with errcheck off in tests). Also rewordedpkg/xsync/pool.go's package doc so it no longer quotes the literal directive.The acceptance gate
Zero
nolint:errcheckanywhere in the tree.Testing
go vet+gofmt -l .clean; binary-blob guard clean.go test … -tags 'dest_kafka dest_nats dest_nsq dest_valkey dest_s3parquet' ./...— entire suite green.golangci-linttiers PASS.This completes the whole effort
s3parquet-destinationstack — destinations, lint sweeps, ~260-commit coverage+bug-fix wave, complexity/integration-test infra, ProtobufList migration, s3parquet — landed onmainone reviewable PR at a time, with several pre-existing bugs/flakes/test-gaps fixed along the way.mainnow passes bothgolangci-linttiers, every error is checked (typedxsync.Pool[T]for the hot pools, checked assertions + real handling elsewhere), and there is no//nolint:errcheckleft.🤖 Generated with Claude Code