[High] Fix unhandled abort during stream cleanup

[randomm]

Problem

In packages/opencode/src/core/stream.ts (lines 365-395), if abort fires during error recovery cleanup, operations continue unsafely.

Impact

Resource leak, corrupted state.

Solution

1. Check abort signal before cleanup operations
2. Wrap cleanup in try-catch
3. Ensure graceful shutdown on abort

Files

• packages/opencode/src/core/stream.ts

Branch

claude/simplify-agentic-loop-2jRSP

[randomm]

Investigation Complete

Location: packages/opencode/src/session/processor.ts lines 54-341

Root Cause

The bug occurs in the main stream processing loop where AbortError can escape the try/catch:

1. throwIfAborted() on line 57 throws inside for await loop
2. Stream iterator internal abort may throw outside try/catch control flow
3. Background tasks spawned during processing may reject after try/catch exits

Secondary Issues Found

• agent.ts (lines 323-325): No try/catch around for await iteration
• tools.ts (lines 92, 134): Tool execution doesn't always handle AbortError
• retry.ts (lines 10-25): AbortError rejection not always caught properly

Recommended Fix

1. Wrap stream iteration in nested try/catch that explicitly checks for AbortError
2. Add AbortError handling in agent.ts stream iteration
3. Improve cleanup section error handling (lines 368-422)
4. Ensure BackgroundTasks.spawn silently ignores AbortError

// Fix pattern for processor.ts
try {
  for await (const value of stream.fullStream) {
    input.abort.throwIfAborted()
    // ... processing
  }
} catch (streamError) {
  if (streamError.name === "AbortError") {
    // Re-throw to outer handler
    throw streamError
  }
  throw streamError
}

Ready for implementation.

[randomm]

Fixed in PR #41. Abort signals are now properly handled during stream cleanup, preventing infinite loops and resource leaks.