Skip to content

add test for permissions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raphaeldussin merged 1 commit into from
Nov 19, 2019
Merged

add test for permissions #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions zarr/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1267,9 +1267,6 @@ def __setitem__(self, key, value):
else:
keyinfo.external_attr = 0o644 << 16 # ?rw-r--r--

if isinstance(value, str):
value = value.encode("utf-8")

self.zf.writestr(keyinfo, value)

def __delitem__(self, key):
Expand Down
16 changes: 16 additions & 0 deletions zarr/tests/test_storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import unittest
from contextlib import contextmanager
from pickle import PicklingError
from zipfile import ZipFile

import numpy as np
import pytest
Expand Down Expand Up @@ -947,6 +948,21 @@ def test_popitem(self):
with pytest.raises(NotImplementedError):
store.popitem()

def test_permissions(self):
store = ZipStore('data/store.zip', mode='w')
store['foo'] = b'bar'
store['baz/'] = b''
store.flush()
store.close()
z = ZipFile('data/store.zip', 'r')
info = z.getinfo('foo')
perm = oct( info.external_attr >> 16 )
assert perm == '0o644'
info = z.getinfo('baz/')
perm = oct( info.external_attr >> 16 )
assert perm == '0o40775'
z.close()


class TestDBMStore(StoreTests, unittest.TestCase):

Expand Down