Use configFile option, support an additional repo deploy key - #175
Merged
Conversation
Contributor
Author
|
The devcontainers builds in rapidsai/cuml#5760 passes, so I think this change is safe. |
bdice
reviewed
Feb 7, 2024
…shared-workflows into fix/devcontainer-json-location
This reverts commit 4f1ac3f.
vyasr
approved these changes
Feb 9, 2024
vyasr
left a comment
vyasr
left a comment
Contributor
There was a problem hiding this comment.
One question but looks good.
Contributor
Author
bdice
approved these changes
Feb 21, 2024
Contributor
Author
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build-in-devcontaineraction use the newconfigFileoptionextra-repo-deploy-keyinbuild-in-devcontaineractionBoth of these changes are necessary to build all the RAPIDS projects in
rapidsai/devcontainersCI jobs.