Skip to content

configs: Drop V4L2 camera and codec drivers from bcmrpi3_defconfig#3030

Merged
pelwell merged 1 commit into
raspberrypi:rpi-4.19.yfrom
6by9:2711_2_fkms
Jun 28, 2019
Merged

configs: Drop V4L2 camera and codec drivers from bcmrpi3_defconfig#3030
pelwell merged 1 commit into
raspberrypi:rpi-4.19.yfrom
6by9:2711_2_fkms

Conversation

@6by9
Copy link
Copy Markdown
Contributor

@6by9 6by9 commented Jun 28, 2019

They rely on mmal_vchiq, which in turn wants vc-sm-cma.
vc-sm-cma needs some attention for 64 bit, so drop it for now.

Signed-off-by: Dave Stevenson dave.stevenson@raspberrypi.org

They rely on mmal_vchiq, which in turn wants vc-sm-cma.
vc-sm-cma needs some attention for 64 bit, so drop it for now.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
@6by9
Copy link
Copy Markdown
Contributor Author

6by9 commented Jun 28, 2019

Temporarily solves #3024 for Pi3.

@pelwell
Copy link
Copy Markdown
Contributor

pelwell commented Jun 28, 2019

For some values of "Solves".

@pelwell pelwell merged commit e8a66b4 into raspberrypi:rpi-4.19.y Jun 28, 2019
@6by9
Copy link
Copy Markdown
Contributor Author

6by9 commented Jun 28, 2019

I'm working on vc-sm-cma still, so will address 64bit support when I get there.

It's not just the cache ioctls - mmal_vchiq can't see some of the functions exported from vc-sm-cma for some reason. I suspect it's related to vc-sm-cma being a bool vs module. Too much black magic in there for a bear of very little brain.

@agherzan
Copy link
Copy Markdown
Contributor

agherzan commented Jun 28, 2019

@pelwell should we remove V4L2 for bcm2711_defconfig as well?

@6by9
Copy link
Copy Markdown
Contributor Author

6by9 commented Jun 28, 2019

arm64/bcm2711_defconfig hasn't been a supported platform, therefore not building isn't a regression.
arm64/bcmrpi3_defconfig not working was a regression.

I know what the issue is with vc-sm-cma. It's working but not quite in a shape to push.
Fixing that is the end goal rather, not dropping features.

@agherzan
Copy link
Copy Markdown
Contributor

I agree, but the "solved" comment points to an issue that is raised against RPI4 which uses bcm2711_defconfig. I don't think it hurts to just have it in both places just for people who want to have an initial try.

@6by9
Copy link
Copy Markdown
Contributor Author

6by9 commented Jun 28, 2019

Earlier comment updated.

pelwell pushed a commit that referenced this pull request Jun 28, 2019
Undefine CONFIG_VIDEO_BCM2835 until it builds for arm64.

See: #3024
See: #3030

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
@pelwell
Copy link
Copy Markdown
Contributor

pelwell commented Jun 28, 2019

@agherzan Yes - see 9d1deec.

@agherzan
Copy link
Copy Markdown
Contributor

Thanks @pelwell . I really appreciate it.

aswild added a commit to aswild/meta-newbs that referenced this pull request Jul 2, 2019
Regression in linux-raspberrypi, vc-sm-cma doesn't build for arm64
currently.

see: raspberrypi/linux#3030
see: raspberrypi/linux@9d1deec
agherzan added a commit to agherzan/meta-raspberrypi that referenced this pull request Jul 2, 2019
agherzan added a commit to agherzan/meta-raspberrypi that referenced this pull request Jul 4, 2019
agherzan added a commit to agherzan/meta-raspberrypi that referenced this pull request Jul 18, 2019
agherzan added a commit to agherzan/meta-raspberrypi that referenced this pull request Jul 20, 2019
TiejunChina pushed a commit that referenced this pull request Jul 23, 2019
Undefine CONFIG_VIDEO_BCM2835 until it builds for arm64.

See: #3024
See: #3030

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants