test: gate tab item geometry to iOS 27 - #183
Conversation
Playwright test resultsDetails
|
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-183/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
rdlabo
left a comment
There was a problem hiding this comment.
The OS-specific tab geometry gate and the search-field reacquisition helpers are reasonable, but I don’t think this should merge with suite-wide retries.
-test-iterations 3 -retry-tests-on-failure applies to every test in both verification scripts, not only to the known search remount race. It can hide deterministic regressions that happen once or twice, can roughly triple suite time, and makes a green run insufficient evidence that the first execution passed. The PR description also confirms that a product-side collapse-on-focus race remains.
Please remove the global retry flags. After #182 lands, also drop the overlapping toolbar-route change and the unrelated generated HTML formatting. Keep the focused search stabilization and the iOS-version-specific item geometry assertion, and track the remaining product race separately rather than treating retries as its resolution.
a05a54c to
1c6a78f
Compare
npm beta publishedCI passed for the merge commit npm install @rdlabo/ionic-theme-ios27@1.0.4-beta.pr183.shaedc618dbeda8 |
Summary
UITabBarmirrors the DOM lens layoutThis intentionally drops the previous suite-wide retry flags, search remount workaround, toolbar-route change superseded by #182, and unrelated generated HTML formatting.
Verification
npm run linttestTabPositionsWebComparisonpassed in light and dark appearance without test retriesThe current
mainsearch fixture failure occurs before the proposed search helper would run and is tracked separately.