Skip to content

test: gate tab item geometry to iOS 27 - #183

Merged
rdlabo merged 1 commit into
mainfrom
fix/issue-181-parity
Sep 21, 2026
Merged

rdlabo merged 1 commit into
mainfrom
fix/issue-181-parity

Conversation

@rdlabo

@rdlabo rdlabo commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep whole-tab-bar geometry checks on every supported OS
  • assert per-item lens geometry only on iOS 27+, where UITabBar mirrors the DOM lens layout
  • leave iOS 26's native equal-width item division as an OS-specific behavior

This intentionally drops the previous suite-wide retry flags, search remount workaround, toolbar-route change superseded by #182, and unrelated generated HTML formatting.

Verification

  • npm run lint
  • iOS 26.5: testTabPositionsWebComparison passed in light and dark appearance without test retries

The current main search fixture failure occurs before the proposed search helper would run and is tracked separately.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Playwright test results

passed  336 passed

Details

stats  336 tests across 18 suites
duration  4 minutes, 24 seconds
commit  1c6a78f
info  This detailed result covers Ionic 9 only. Ionic 8 runs against the same screenshots in a separate matrix job; check the workflow run for both results. To update the screenshots, comment with /update-screenshots.

github-actions Bot added a commit that referenced this pull request Sep 16, 2026
github-actions Bot added a commit that referenced this pull request Sep 16, 2026
@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-183/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 16, 2026

@rdlabo rdlabo left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OS-specific tab geometry gate and the search-field reacquisition helpers are reasonable, but I don’t think this should merge with suite-wide retries.

-test-iterations 3 -retry-tests-on-failure applies to every test in both verification scripts, not only to the known search remount race. It can hide deterministic regressions that happen once or twice, can roughly triple suite time, and makes a green run insufficient evidence that the first execution passed. The PR description also confirms that a product-side collapse-on-focus race remains.

Please remove the global retry flags. After #182 lands, also drop the overlapping toolbar-route change and the unrelated generated HTML formatting. Keep the focused search stabilization and the iOS-version-specific item geometry assertion, and track the remaining product race separately rather than treating retries as its resolution.

@rdlabo
rdlabo force-pushed the fix/issue-181-parity branch from a05a54c to 1c6a78f Compare September 21, 2026 04:03
@rdlabo rdlabo changed the title fix(test): tolerate search remount races and OS-specific tab layout (#181) test: gate tab item geometry to iOS 27 Sep 21, 2026
@rdlabo
rdlabo merged commit edc618d into main Sep 21, 2026
16 of 19 checks passed
github-actions Bot added a commit that referenced this pull request Sep 21, 2026
github-actions Bot added a commit that referenced this pull request Sep 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

npm beta published

CI passed for the merge commit edc618dbeda8. Install the immutable version with:

npm install @rdlabo/ionic-theme-ios27@1.0.4-beta.pr183.shaedc618dbeda8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant