Skip to content

fix: table header broken when scroll do not have the data(#594) - #595

Merged
xrkffgg merged 1 commit into
react-component:masterfrom
geekrainy:master
Mar 18, 2021
Merged

fix: table header broken when scroll do not have the data(#594)#595
xrkffgg merged 1 commit into
react-component:masterfrom
geekrainy:master

Conversation

@geekrainy

Copy link
Copy Markdown
Contributor

Before:
before
After:
after

@vercel

vercel Bot commented Mar 17, 2021

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/table/AV89FeJAvYaMrmLhvLdufnfBaoW6
✅ Preview: https://table-git-fork-geekrainy-master-react-component.vercel.app

@geekrainy

Copy link
Copy Markdown
Contributor Author

@zombieJ

@codecov

codecov Bot commented Mar 18, 2021

Copy link
Copy Markdown

Codecov Report

Merging #595 (8a6a278) into master (d5c3bae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 8a6a278 differs from pull request most recent head a851a30. Consider uploading reports for the commit a851a30 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #595   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          26       26           
  Lines         811      812    +1     
  Branches      237      238    +1     
=======================================
+ Hits          809      810    +1     
  Misses          2        2           
Impacted Files Coverage Δ
src/Header/FixedHeader.tsx 100.00% <100.00%> (ø)
src/Table.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5c3bae...a851a30. Read the comment docs.

@xrkffgg

xrkffgg commented Mar 18, 2021

Copy link
Copy Markdown
Member

空数据的时候 头部不能变?

@geekrainy

Copy link
Copy Markdown
Contributor Author

@xrkffgg 对,如果列很多,空数据头部会被挤成很窄的情况,和有数据的状态下表现不一致。

@xrkffgg
xrkffgg merged commit b0a09b6 into react-component:master Mar 18, 2021
@xrkffgg

xrkffgg commented Mar 18, 2021

Copy link
Copy Markdown
Member
+ rc-table@7.13.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants