Skip to content

fix: readConfigFromDisk should ignore package.json entries#2472

Merged
szymonrybczak merged 1 commit into
mainfrom
@vonovak/patch-1
Aug 23, 2024
Merged

fix: readConfigFromDisk should ignore package.json entries#2472
szymonrybczak merged 1 commit into
mainfrom
@vonovak/patch-1

Conversation

@vonovak

@vonovak vonovak commented Aug 14, 2024

Copy link
Copy Markdown
Member

Summary:

I was trying out 0.75 and not sure why is worked before, but now the config command returned this value - literally "src/index", instead of the value influenced by the config file.

Test Plan:

npx react-native config returned a valid result in the repo

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@thymikee

Copy link
Copy Markdown
Member

@szymonrybczak mind looking at it? I'm not sure why we haven't used searchPlaces param for reading from disk.

@vonovak

vonovak commented Aug 20, 2024

Copy link
Copy Markdown
Member Author

It was there before, but was removed with https://github.com/react-native-community/cli/pull/2343/files
Looks like a mistake to me?

@szymonrybczak szymonrybczak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants