Fix broken link#4330
Conversation
Update User Guide's README.md to include `json` and `css` files in the command to format the entire project for the first time with prettier, that it's consistent with the `lint-staged` command.
This reverts commit bab2c29. I meant to apply it to `next` instead.
Support for .mjs files added in #3239 did not account for npm libraries which ship native mjs files alongside js files. This accounts for this by ensuring .js files resolve before their accompanying .mjs file. Note that this is not an ideal end state since selecting a .mjs over a .js extension should be the result of whether `import` was used instead of `require()` in a node environment with native ESM support (currently via `--experimental-modules`). Instead, this change just *always* selects a .js extension before the .mjs extension if it exists. This unbreaks support for using GraphQL (relay, apollo, etc) within create-react-app projects.
Add troubleshooting for an issue that has to do with either 2FA, or using Windows, or both, when trying to deploy an app via gh-pages
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Can you please target this at |
|
@Timer Sure, there you have it. Now how do we get rid of "Merge branch 'next' into patch-1" commit from the commit history? |
|
It may be easier to re-submit this PR against next via closing it and re-editing. |
|
@Timer I'll try to figure out the right way, without re-submitting the issue. |
|
Seems like the fixed link has already made it to the |
10 participants
No description provided.