Skip HMR client setup when bundle is not from Metro - #58428
Open
javache wants to merge 1 commit into
Open
Conversation
Summary: When the JS bundle is loaded from a local file (bundled with the app or restored from disk), `HMRClient.setup()` still runs during startup and registers an entry-point with the packager over the fallback `/hot?bundleEntry=...` URL. There is no coherent module map to hot-reload against, so the packager side logs an "Unable to resolve module" error. Gate `setup()` on `getDevServer().bundleLoadedFromServer` and early-return with a `console.warn` when the bundle did not come from Metro. The user still sees why HMR is unavailable in this session, but the noisy resolver error goes away. Changelog: [General][Fixed] - Skip HMR client setup when the JS bundle was not loaded from Metro Differential Revision: D110603320
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110603320. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When the JS bundle is loaded from a local file (bundled with the app or restored from disk),
HMRClient.setup()still runs during startup and registers an entry-point with the packager over the fallback/hot?bundleEntry=...URL. There is no coherent module map to hot-reload against, so the packager side logs an "Unable to resolve module" error.Gate
setup()ongetDevServer().bundleLoadedFromServerand early-return with aconsole.warnwhen the bundle did not come from Metro. The user still sees why HMR is unavailable in this session, but the noisy resolver error goes away.Changelog:
[General][Fixed] - Skip HMR client setup when the JS bundle was not loaded from Metro
Differential Revision: D110603320