Skip to content

Skip HMR client setup when bundle is not from Metro #58428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javache wants to merge 1 commit into from
+12 −0
Closed

Skip HMR client setup when bundle is not from Metro #58428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/react-native/Libraries/Utilities/HMRClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,18 @@ const HMRClient: HMRClientNativeInterface = {
invariant(host, 'Missing required parameter `host`');
invariant(!hmrClient, 'Cannot initialize hmrClient twice');

// HMR requires a Metro-served bundle so the server can map source edits back
// to the running module set. When the bundle was loaded from a local file
// there's nothing to hot-reload — registering with the server would just log
// spurious "Unable to resolve module" errors.
if (!getDevServer().bundleLoadedFromServer) {
console.warn(
'Not enabling Hot Module Reloading: the JS bundle was loaded from a local ' +
'file, not from Metro. To use HMR, load the bundle from the packager.',
);
return;
}

// Moving to top gives errors due to NativeModules not being initialized
const DevLoadingView = require('./DevLoadingView').default;

Expand Down
Loading