Added sharedAction example to Share API#30333
Conversation
|
Hi @kshitij86! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
react-native-bot
added
the
Type: Enhancement
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Base commit: 53862a1 |
Base commit: 017bc91 |
mkcode
force-pushed
the
mlh-fellowship-examples-share
branch
from
f4e129a to
5d0ba69
Compare
|
This great to me. |
|
@rickhanlonii Could you please review these changes? |
|
Looks like the android test failed, I re-ran the jobs and if it passes I'll import it. |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
| // eslint-disable-next-line dot-notation | ||
| const isFabric = !!( | ||
| this._ref && this._ref['_internalInstanceHandle']?.stateNode?.canonical | ||
| this._ref && this._ref._internalInstanceHandle?.stateNode?.canonical |
There was a problem hiding this comment.
Could we revert this?
|
@rickhanlonii merged this pull request in 835117a. |
Summary: Changelog: [internal] Revert a change introduced in #30333 where rickhanlonii asked it to be reverted as well. The change breaks sticky header in Fabric. Reviewed By: rubennorte Differential Revision: D25883861 fbshipit-source-id: b01305c6def390d0664c7be939ab3fc72186a07a
Summary: Changelog: [internal] Revert a change introduced in react#30333 where rickhanlonii asked it to be reverted as well. The change breaks sticky header in Fabric. Reviewed By: rubennorte Differential Revision: D25883861 fbshipit-source-id: b01305c6def390d0664c7be939ab3fc72186a07a
6 participants
Summary
sharedActionanddismissedActionin Share API examplesMotivation - Missing example for
sharedActionin examplesChangelog
[General] [Added] - Added an example in ShareExample.js
Test Plan