Skip to content

Fix InputType for url keyboard in Android - #36436

Closed
jeswinsimon wants to merge 1 commit into
react:mainfrom
jeswinsimon:android-url-keyboard-fix
Closed

Fix InputType for url keyboard in Android#36436
jeswinsimon wants to merge 1 commit into
react:mainfrom
jeswinsimon:android-url-keyboard-fix

Conversation

@jeswinsimon

Copy link
Copy Markdown
Contributor

Summary

Fix for #35651

Changelog

[ANDROID][FIXED] - Updated InputType for TextView

Test Plan

Autofill suggestions should be visible if keyboardType='url' for TextInput

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 10, 2023
@analysis-bot

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,516,929 +8
android hermes armeabi-v7a 7,832,603 +20
android hermes x86 8,997,356 +3
android hermes x86_64 8,852,544 -5
android jsc arm64-v8a 9,140,992 +1
android jsc armeabi-v7a 8,332,490 +1
android jsc x86 9,195,845 +2
android jsc x86_64 9,453,893 +2

Base commit: e68f513
Branch: main

@XantreDev

Copy link
Copy Markdown
Contributor

Is it works fine?

@ryancat

ryancat commented Mar 10, 2023

Copy link
Copy Markdown
Contributor

Thanks for fixing this. Could you add a screen record as test plan for this fix?

@github-actions

github-actions Bot commented Sep 7, 2023

Copy link
Copy Markdown

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Sep 7, 2023
@XantreDev

Copy link
Copy Markdown
Contributor

How to test it?

@github-actions github-actions Bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Sep 8, 2023
@github-actions

github-actions Bot commented Mar 7, 2024

Copy link
Copy Markdown

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Mar 7, 2024
@XantreDev

Copy link
Copy Markdown
Contributor

Will it be merged?

@github-actions github-actions Bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Mar 8, 2024
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Apr 18, 2024
@XantreDev

Copy link
Copy Markdown
Contributor

@ryancat pretty much sure that this is a correct combination of flags. How we can prove that it's working? https://gist.github.com/lopspower/ff2fec6c16991c072495#:~:text=textUri,TYPE_CLASS_TEXT%20/%20TYPE_TEXT_VARIATION_URI

@react-native-bot

Copy link
Copy Markdown
Collaborator

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@react-native-bot react-native-bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Nov 30, 2024
@react-native-bot

Copy link
Copy Markdown
Collaborator

This PR was closed because it has been stalled for 7 days with no activity.

@react-native-bot react-native-bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Dec 7, 2024
@XantreDev

Copy link
Copy Markdown
Contributor

Bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants