Skip to content

C++ style enums 15/N: Display#39541

Closed
NickGerleman wants to merge 8 commits into
react:mainfrom
NickGerleman:export-D49361952
Closed

C++ style enums 15/N: Display#39541
NickGerleman wants to merge 8 commits into
react:mainfrom
NickGerleman:export-D49361952

Conversation

@NickGerleman

Copy link
Copy Markdown
Contributor

Summary:
X-link: react/yoga#1397

Moves internal usages of YGDisplay to Display
Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D49361952

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Sep 19, 2023
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D49361952

NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
Summary:
X-link: react/react-native#39541

Pull Request resolved: react#1397

Moves internal usages of YGDisplay to Display
Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D49361952

fbshipit-source-id: 1c87400d12732772df7b932b09ab429644d29429
@analysis-bot

analysis-bot commented Sep 19, 2023

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,333,822 +51
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,573,346 +80
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 95fb448
Branch: main

NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
Summary:
X-link: react/react-native#39541

Pull Request resolved: react#1397

Moves internal usages of YGDisplay to Display
Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D49361952

fbshipit-source-id: 841da62bd85d1951d1f821a5b236e985715d2619
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D49361952

NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
Summary:
X-link: react/react-native#39541

Pull Request resolved: react#1397

Moves internal usages of YGDisplay to Display
Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D49361952

fbshipit-source-id: d37512586d7f88f98c0ce05eda29df67984d67f6
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D49361952

NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
Summary:
X-link: react/react-native#39541

Pull Request resolved: react#1397

Moves internal usages of YGDisplay to Display
Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D49361952

fbshipit-source-id: c4f35cb41848788262619d1628ac8cbdb152d8c8
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D49361952

NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
Summary:
X-link: react/react-native#39541

Pull Request resolved: react#1397

Moves internal usages of YGDisplay to Display
Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D49361952

fbshipit-source-id: 3d407e6ce1c1000f7a15b7211ea20dc52f2143b1
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D49361952

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D49361952

NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
Summary:
X-link: react/react-native#39541

Pull Request resolved: react#1397

Moves internal usages of YGDisplay to Display
Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D49361952

fbshipit-source-id: eda020a1cd7058e694bebda28037ad7ec170ab23
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D49361952

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D49361952

NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
Summary:
X-link: react/react-native#39541

Pull Request resolved: react#1397

Moves internal usages of YGDisplay to Display

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D49361952

fbshipit-source-id: c438f19f66f0367f98f0ba02987ffd42b66a0b5b
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D49361952

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D49361952

NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
Summary:
X-link: react/react-native#39541

Pull Request resolved: react#1397

Moves internal usages of YGDisplay to Display

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D49361952

fbshipit-source-id: 4e8260b34af4166b72f6037f5bbfc2a52cc5c037
NickGerleman and others added 8 commits September 19, 2023 11:24
Summary: Moves internal usages of YGDirection to Direction.

Differential Revision: D49335231

fbshipit-source-id: e9e866ffe2f7d73622852b17b0eb736ee75d0684
Summary: Moves internal usages of YGDirection to Direction.

Differential Revision: https://www.internalfb.com/diff/D49336066?entry_point=27

fbshipit-source-id: f167994d1bc1d8d15d3f3cfff4037ec6e7c319a0
Summary: Moves internal usages of YGJustify to Justify.

Differential Revision: https://internalfb.com/D49336538

fbshipit-source-id: deb5667b442dca8344384181ab214cf6781aad02
Summary:
Moves internal usages of YGAlign to Align

Changelog: [Internal]

Differential Revision: https://internalfb.com/D49337511

fbshipit-source-id: 29844665c200bf2f304f51cf0ae3cc2fd3cf79dc
Summary:
Moves internal usages of YGPositionType to PositionType

Changelog: [Internal]

Differential Revision: D49361677

fbshipit-source-id: d5ec1bc5fbfe3baf518fbce23d0801eeb1597471
Summary:
Moves internal usages of YGPositionType to PositionType
Changelog: [Internal]

Differential Revision: D49361746

fbshipit-source-id: 009274682bf3e04678cedeeaf2affa3fe871fd53
Summary:
Moves internal usages of YGOverflow to Overflow
Changelog: [Internal]

Differential Revision: D49361843

fbshipit-source-id: cf44a65c0adda359e2c740b01ddc9ad80a274d65
Summary:
Pull Request resolved: react#39541

X-link: react/yoga#1397

Moves internal usages of YGDisplay to Display

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D49361952

fbshipit-source-id: 8296137ec15917a27533fdc36eea6125cf2a0f05
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D49361952

NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
Summary:
X-link: react/react-native#39541

Pull Request resolved: react#1397

Moves internal usages of YGDisplay to Display

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D49361952

fbshipit-source-id: d1fe57e65ff3ffcd579450479a53d57f68636738
@github-actions

github-actions Bot commented Sep 19, 2023

Copy link
Copy Markdown
Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 1e57c6317eb3c0baf45c6adbb32f29c4108f7aaa

facebook-github-bot pushed a commit to facebook/litho that referenced this pull request Sep 19, 2023
Summary:
X-link: react/react-native#39541

X-link: react/yoga#1397

Moves internal usages of YGDisplay to Display

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D49361952

fbshipit-source-id: a961efaa35a3fed01659d23783bf90e0b47656f0
facebook-github-bot pushed a commit to react/yoga that referenced this pull request Sep 19, 2023
Summary:
X-link: react/react-native#39541

Pull Request resolved: #1397

Moves internal usages of YGDisplay to Display

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D49361952

fbshipit-source-id: a961efaa35a3fed01659d23783bf90e0b47656f0
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 19, 2023
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in ebcd1ab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants