feat(iOS): add modal detents prop - #54273
Open
okwasniewski wants to merge 2 commits into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-bot
added
p: Callstack
cipolleschi
approved these changes
Oct 27, 2025
cipolleschi
left a comment
cipolleschi
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding this long wanted, awaited feature @okwasniewski!
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D85554807. |
cipolleschi
reviewed
Oct 27, 2025
Collaborator
|
okwasniewski
force-pushed
the
feat/modal-detents
branch
from
October 30, 2025 16:05
9442baa to
e4b3e50
Compare
okwasniewski
force-pushed
the
feat/modal-detents
branch
from
October 30, 2025 16:10
e4b3e50 to
f25ce97
Compare
|
commenting to follow along |
Collaborator
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
react-native-bot
added
the
Stale
Collaborator
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
react-native-bot
removed
the
Stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR builds off the amazing work that @hurali97 did back in 2023. #34834
The previous PR didn't land because of significant delays when resizing the modal. Thanks to recent improvements we are now able to emit state updates synchronously thanks to
EventQueue::UpdateMode::unstable_Immediate.This PR builds off on that making the modal resizing buttery smooth.
modal.detents.mp4
Changelog:
[IOS] [ADDED] - implement modal detents prop
Test Plan: