Update test-release-local script#54385
Closed
j-piasecki wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86105703. |
j-piasecki
force-pushed
the
export-D86105703
branch
from
November 3, 2025 16:27
b215d20 to
ff998b4
Compare
j-piasecki
changed the title
test-release-local script
j-piasecki
force-pushed
the
export-D86105703
branch
from
November 4, 2025 07:10
ff998b4 to
4172ecd
Compare
Summary: Pull Request resolved: #54385 Changelog: [Internal] `test-release-local` shouldn't be changing the hermes version stored in `version.properties` as this script should be called on a cut branch with hermes already bumped. Reviewed By: cipolleschi Differential Revision: D86105703
j-piasecki
force-pushed
the
export-D86105703
branch
from
November 4, 2025 07:14
4172ecd to
3e6546c
Compare
|
This pull request has been merged in 30370f6. |
Collaborator
|
This pull request was successfully merged by @j-piasecki in 30370f6 When will my fix make it into a release? | How to file a pick request? |
cipolleschi
pushed a commit
that referenced
this pull request
Nov 4, 2025
Summary: Pull Request resolved: #54385 Changelog: [Internal] `test-release-local` shouldn't be changing the hermes version stored in `version.properties` as this script should be called on a cut branch with hermes already bumped. Reviewed By: cipolleschi Differential Revision: D86105703 fbshipit-source-id: 5a1edd9f7a6cd756521749c2b0023ea683dadf82
Collaborator
|
This pull request was successfully merged by @j-piasecki in e23a285 When will my fix make it into a release? | How to file a pick request? |
This was referenced Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
test-release-localis not a ES6 module and it should use require instead of import.Differential Revision: D86105703