Skip to content

Add integration tests for multi-session Debugger.enable #55542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
motiz88 wants to merge 1 commit into from
Closed

Add integration tests for multi-session Debugger.enable #55542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 67 additions & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/tests/JsiIntegrationTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,6 +738,73 @@ TYPED_TEST(JsiIntegrationHermesTest, ResolveColumnBreakpointAfterReload) {
scriptInfo->value()["params"]["scriptId"]);
}

TYPED_TEST(JsiIntegrationHermesTest, TwoConnectionsEnableDebugger) {
this->connect();
auto secondary = this->connectSecondary();

EXPECT_CALL(
this->fromPage(), onMessage(JsonEq(R"({"id": 1, "result": {}})")));
EXPECT_CALL(
secondary.fromPage(), onMessage(JsonEq(R"({"id": 2, "result": {}})")));

this->toPage_->sendMessage(R"({"id": 1, "method": "Debugger.enable"})");
secondary.toPage().sendMessage(R"({"id": 2, "method": "Debugger.enable"})");
}

TYPED_TEST(JsiIntegrationHermesTest, TwoConnectionsDebuggerLifecycle) {
this->connect();
auto secondary = this->connectSecondary();

this->expectMessageFromPage(JsonEq(R"({"id": 1, "result": {}})"));
this->toPage_->sendMessage(R"({"id": 1, "method": "Debugger.enable"})");

// Connections: Main (Debugger enabled), Secondary (Debugger disabled)
// --> Only the main connection receives Debugger events.
this->expectMessageFromPage(JsonParsed(AllOf(
AtJsonPtr("/method", "Debugger.scriptParsed"),
AtJsonPtr("/params/url", "script1.js"))));
this->eval("1 + 1; //# sourceURL=script1.js");

// Connections: Main (Debugger enabled), Secondary (Debugger being enabled)
// --> The secondary connection receives buffered Debugger events.
EXPECT_CALL(
secondary.fromPage(), onMessage(JsonEq(R"({"id": 2, "result": {}})")));
EXPECT_CALL(
secondary.fromPage(),
onMessage(JsonParsed(AllOf(
AtJsonPtr("/method", "Debugger.scriptParsed"),
AtJsonPtr("/params/url", "script1.js")))));
secondary.toPage().sendMessage(R"({"id": 2, "method": "Debugger.enable"})");

// Connections: Main (Debugger enabled), Secondary (Debugger enabled)
// --> Both connections receive Debugger events.
this->expectMessageFromPage(JsonParsed(AllOf(
AtJsonPtr("/method", "Debugger.scriptParsed"),
AtJsonPtr("/params/url", "script2.js"))));
EXPECT_CALL(
secondary.fromPage(),
onMessage(JsonParsed(AllOf(
AtJsonPtr("/method", "Debugger.scriptParsed"),
AtJsonPtr("/params/url", "script2.js")))));
this->eval("2 + 2; //# sourceURL=script2.js");

this->expectMessageFromPage(JsonEq(R"({"id": 3, "result": {}})"));
this->toPage_->sendMessage(R"({"id": 3, "method": "Debugger.disable"})");

// Connections: Main (Debugger disabled), Secondary (Debugger enabled)
// --> Only the secondary connection receives Debugger events.
EXPECT_CALL(
secondary.fromPage(),
onMessage(JsonParsed(AllOf(
AtJsonPtr("/method", "Debugger.scriptParsed"),
AtJsonPtr("/params/url", "script3.js")))));
this->eval("3 + 3; //# sourceURL=script3.js");

EXPECT_CALL(
secondary.fromPage(), onMessage(JsonEq(R"({"id": 4, "result": {}})")));
secondary.toPage().sendMessage(R"({"id": 4, "method": "Debugger.disable"})");
}

TYPED_TEST(JsiIntegrationHermesTest, CDPAgentReentrancyRegressionTest) {
this->connect();

Expand Down
Loading