Remove test code from the cxx-api snapshot (#56173) - #56173
Closed
coado wants to merge 3 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
meta-codesync
Bot
changed the title
coado
force-pushed
the
export-D97457090
branch
2 times, most recently
from
March 20, 2026 11:38
1691d83 to
d90979f
Compare
cortinico
approved these changes
Mar 20, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
coado
force-pushed
the
export-D97457090
branch
6 times, most recently
from
March 27, 2026 11:13
b704d6b to
8f949e1
Compare
added 2 commits
March 31, 2026 04:30
Summary: This diff introduces initial snapshots of the Cxx public API in a form of a couple .api files, namely: - ReactAndroidDebugCxx.api - ReactAndroidReleaseCxx.api - ReactAppleDebugCxx.api - ReactAppleReleaseCxx.api - ReactCommonDebugCxx.api - ReactCommonReleaseCxx.api that is for `ReactAndroid`, `ReactApple`, and shared `ReactCommon` in two variants `Release` and `Debug` each. Differential Revision: D97296573
Summary: Pull Request resolved: #56042 Adds CI workflow for validating whether the current C++ API snapshot is equivalent with the generated one. Changelog: [Internal] Differential Revision: D95963515
Summary: Pull Request resolved: #56173 Removes leaked test code from the snapshot. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D97457090
|
This pull request has been merged in 3a80179. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Removes leaked test code from the snapshot.
Changelog:
[Internal]
Reviewed By: cortinico
Differential Revision: D97457090