Cover react/renderer/core with stable API guards (#58374) - #58374
Open
j-piasecki wants to merge 1 commit into
Open
Cover react/renderer/core with stable API guards (#58374)#58374j-piasecki wants to merge 1 commit into
react/renderer/core with stable API guards (#58374)#58374j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119065020. |
j-piasecki
force-pushed
the
export-D119065020
branch
from
September 9, 2026 12:46
009a523 to
96d5116
Compare
meta-codesync
Bot
changed the title
react/renderer/core with stable API guardsreact/renderer/core with stable API guards (#58374)
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 9, 2026
Summary: Pull Request resolved: react#58374 Classifies `react/renderer/core:core` and `react/renderer/core:rawValue` as public targets under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the modules' 50 exported headers and introduces the module umbrellas `React/RendererCore.h` and `React/RawValue.h`, wiring the guard dependency into BUCK and CMake and the umbrellas into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export. Consumers that opt into `RN_STRICT_API` now get an error if they include the modules' headers directly, and should include `<React/RendererCore.h>` or `<React/RawValue.h>` instead; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [General][Added] - Added umbrella headers for `react/renderer/core:core` and `react/renderer/core:rawValue` modules Differential Revision: D119065020
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 11, 2026
Summary: Pull Request resolved: react#58374 Classifies `react/renderer/core:core` and `react/renderer/core:rawValue` as public targets under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the modules' 50 exported headers and introduces the module umbrellas `React/RendererCore.h` and `React/RawValue.h`, wiring the guard dependency into BUCK and CMake and the umbrellas into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export. Consumers that opt into `RN_STRICT_API` now get an error if they include the modules' headers directly, and should include `<React/RendererCore.h>` or `<React/RawValue.h>` instead; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [General][Added] - Added umbrella headers for `react/renderer/core:core` and `react/renderer/core:rawValue` modules Differential Revision: D119065020
j-piasecki
force-pushed
the
export-D119065020
branch
from
September 11, 2026 09:26
96d5116 to
91fe81f
Compare
Summary: Pull Request resolved: react#58374 Classifies `react/renderer/core:core` and `react/renderer/core:rawValue` as public targets under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the modules' 50 exported headers and introduces the module umbrellas `React/RendererCore.h` and `React/RawValue.h`, wiring the guard dependency into BUCK and CMake and the umbrellas into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export. Consumers that opt into `RN_STRICT_API` now get an error if they include the modules' headers directly, and should include `<React/RendererCore.h>` or `<React/RawValue.h>` instead; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [General][Added] - Added umbrella headers for `react/renderer/core:core` and `react/renderer/core:rawValue` modules Differential Revision: D119065020
j-piasecki
force-pushed
the
export-D119065020
branch
from
September 11, 2026 09:31
91fe81f to
098eda3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Classifies
react/renderer/core:coreandreact/renderer/core:rawValueas public targets under the C++ stable API three-tier visibility model. Adds#include <react/cxxstableapi/UmbrellaGuard.h>to the modules' 50 exported headers and introduces the module umbrellasReact/RendererCore.handReact/RawValue.h, wiring the guard dependency into BUCK and CMake and the umbrellas into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export.Consumers that opt into
RN_STRICT_APInow get an error if they include the modules' headers directly, and should include<React/RendererCore.h>or<React/RawValue.h>instead; without that flag the guards are inert, so no existing build changes behaviour.Changelog: [General][Added] - Added umbrella headers for
react/renderer/core:coreandreact/renderer/core:rawValuemodulesDifferential Revision: D119065020