Make react/renderer/imagemanager public (#58438) - #58438
Closed
j-piasecki wants to merge 2 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119477737. |
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 10, 2026
Summary: Pull Request resolved: react#58438 Classifies `react/renderer/imagemanager:imagemanager` as a public target under the C++ stable API three-tier visibility model. Replaces the `FrameworksGuard.h` include in the module's 7 exported headers with `<react/cxxstableapi/UmbrellaGuard.h>` and introduces the module umbrella `React/ImageManager.h`, wiring the umbrella into BUCK, CMake, CocoaPods, the iOS prebuild header config and the Android prefab export. Changelog: [General][Added] - Added umbrella header for the `react/renderer/imagemanager` module Differential Revision: D119477737
meta-codesync
Bot
changed the title
react/renderer/imagemanager publicreact/renderer/imagemanager public (#58438)
j-piasecki
force-pushed
the
export-D119477737
branch
from
September 10, 2026 13:52
01fd4b6 to
935aa5d
Compare
cortinico
approved these changes
Sep 10, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Summary: Classifies `react/renderer/components/image:image` as a public target under the C++ stable API three-tier visibility model. Replaces the `FrameworksGuard.h` include in the module's 6 exported headers with `<react/cxxstableapi/UmbrellaGuard.h>` and introduces the module umbrella `React/Image.h`, wiring the umbrella into BUCK, CMake, CocoaPods, the iOS prebuild header config and the Android prefab export. Changelog: [General][Added] - Added umbrella header for the `react/renderer/components/image` module Differential Revision: D119477736
Summary: Pull Request resolved: react#58438 Classifies `react/renderer/imagemanager:imagemanager` as a public target under the C++ stable API three-tier visibility model. Replaces the `FrameworksGuard.h` include in the module's 7 exported headers with `<react/cxxstableapi/UmbrellaGuard.h>` and introduces the module umbrella `React/ImageManager.h`, wiring the umbrella into BUCK, CMake, CocoaPods, the iOS prebuild header config and the Android prefab export. Changelog: [General][Added] - Added umbrella header for the `react/renderer/imagemanager` module Reviewed By: cortinico Differential Revision: D119477737
j-piasecki
force-pushed
the
export-D119477737
branch
from
September 11, 2026 06:39
935aa5d to
4590053
Compare
|
This pull request has been merged in be53e3a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Classifies
react/renderer/imagemanager:imagemanageras a public target under the C++ stable API three-tier visibility model. Replaces theFrameworksGuard.hinclude in the module's 7 exported headers with<react/cxxstableapi/UmbrellaGuard.h>and introduces the module umbrellaReact/ImageManager.h, wiring the umbrella into BUCK, CMake, CocoaPods, the iOS prebuild header config and the Android prefab export.Changelog:
[General][Added] - Added umbrella header for the
react/renderer/imagemanagermoduleReviewed By: cortinico
Differential Revision: D119477737