Resolve umbrella headers in CMake builds (#58483) - #58483
Closed
j-piasecki wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119662087. |
facebook-github-tools
Bot
added
p: Software Mansion
cortinico
approved these changes
Sep 11, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Summary: The `React/*.h` umbrella headers for `react/renderer/components/view`, `react/debug` and `react/renderer/mapbuffer` are exported by every build system except CMake, so `#include <React/View.h>`, `<React/Debug.h>` and `<React/MapBuffer.h>` fail to resolve there. Add the missing `target_include_directories(<target> INTERFACE ...)` entry to each module, matching what the other umbrella-exporting modules already do. Changelog: [Android][Fixed] - Make the `React/View.h`, `React/Debug.h` and `React/MapBuffer.h` umbrella headers resolvable in CMake builds Reviewed By: cortinico Differential Revision: D119662087
meta-codesync
Bot
changed the title
j-piasecki
force-pushed
the
export-D119662087
branch
from
September 12, 2026 19:52
832f368 to
15ae154
Compare
|
This pull request has been merged in b936db9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
React/*.humbrella headers forreact/renderer/components/view,react/debugandreact/renderer/mapbufferare exported by every build system except CMake, so#include <React/View.h>,<React/Debug.h>and<React/MapBuffer.h>fail to resolve there.Add the missing
target_include_directories(<target> INTERFACE ...)entry to each module, matching what the other umbrella-exporting modules already do.Changelog:
[Android][Fixed] - Make the
React/View.h,React/Debug.handReact/MapBuffer.humbrella headers resolvable in CMake buildsReviewed By: cortinico
Differential Revision: D119662087