Skip to content

Make the whole Navbar mobile menu row tappable (two-tap bug) #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bencounsell wants to merge 1 commit into
base: main
Choose a base branch
from
+58 −41
Open

Make the whole Navbar mobile menu row tappable (two-tap bug) #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 24 additions & 28 deletions ....elementsdevpack/components/com.realmacsoftware.navbar/templates/include/mobile_item.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,49 +1,45 @@
<li x-data="{ open: false }" class="cursor-pointer">
<div
class="{{classes.mobile.item}} flex items-center justify-between"
@click="open = !open"
@if(page.isActive)
aria-current="page"
@endif
@if(page.hasActiveChild)
data-active-child
@endif
>
@if(page.isFolder)
<button
aria-expanded="false"
x-bind:aria-expanded="open.toString()"
class="flex justify-between items-center"
@if(page.isActive)
aria-current="page"
@endif
>
<span>{{page.title}}</span>
@include("mobile_submenu_indicator")
</button>
@else
<li x-data="{ open: false }">
@if(page.hasPages)
<div class="flex items-stretch justify-between">
<a
class="flex justify-between items-center"
class="{{classes.mobile.item}} flex flex-1 items-center"
href="{{page.url}}"
@if(page.isActive)
aria-current="page"
@endif
@if(page.hasActiveChild)
data-active-child
@endif
@if(page.openInNewWindow)
target="_blank"
@endif
>{{page.title}}</a
>
@if(page.hasPages)
<button
@click.stop="open = !open"
aria-expanded="false"
x-bind:aria-expanded="open.toString()"
class="pl-2"
class="flex cursor-pointer items-center pl-2"
>
@include("mobile_submenu_indicator")
</button>
@endif @endif
</div>
@else
<a
class="{{classes.mobile.item}} block"
href="{{page.url}}"
@if(page.isActive)
aria-current="page"
@endif
@if(page.hasActiveChild)
data-active-child
@endif
@if(page.openInNewWindow)
target="_blank"
@endif
>{{page.title}}</a
>
@endif

@includeIf(page.hasPages, template: "mobile_submenu")
</li>
47 changes: 34 additions & 13 deletions ...ementsdevpack/components/com.realmacsoftware.navbar/templates/include/mobile_submenu.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,28 +21,49 @@
<span>{{child.title}}</span>
@include("mobile_submenu_indicator")
</button>
@else
<div
class="{{classes.mobile.item}} flex justify-between items-center"
@if(child.isActive)
aria-current="page"
@endif
@if(child.hasActiveChild)
data-active-child
@endif
>
@else @if(child.hasPages)
<div class="flex items-stretch justify-between">
<a
class="block"
class="{{classes.mobile.item}} flex flex-1 items-center"
href="{{child.url}}"
@click.stop
@if(child.isActive)
aria-current="page"
@endif
@if(child.hasActiveChild)
data-active-child
@endif
@if(child.openInNewWindow)
target="_blank"
@endif
>{{child.title}}</a
>
@includeIf(child.hasPages, template: "mobile_submenu_indicator")
<button
@click.stop="open = !open"
aria-expanded="false"
x-bind:aria-expanded="open.toString()"
class="flex cursor-pointer items-center pl-2"
>
@include("mobile_submenu_indicator")
</button>
</div>
@endif @includeIf(child.hasPages, template: "mobile_submenu_menu")
@else
<a
class="{{classes.mobile.item}} block"
href="{{child.url}}"
@click.stop
@if(child.isActive)
aria-current="page"
@endif
@if(child.hasActiveChild)
data-active-child
@endif
@if(child.openInNewWindow)
target="_blank"
@endif
>{{child.title}}</a
>
@endif @endif @includeIf(child.hasPages, template: "mobile_submenu_menu")
</li>
@endeach
</ul>