Skip to content

[PHPUnit12] Handle crash on property not exists on PropertyCreateMockToCreateStubRector#681

Merged
samsonasik merged 2 commits into
mainfrom
prop-not-exists
Jun 2, 2026
Merged

[PHPUnit12] Handle crash on property not exists on PropertyCreateMockToCreateStubRector#681
samsonasik merged 2 commits into
mainfrom
prop-not-exists

Conversation

@samsonasik
Copy link
Copy Markdown
Member

Given the following code:

use PHPUnit\Framework\TestCase;

final class SkipPropertyNotExistsTest extends TestCase
{
    protected function setUp(): void
    {
        $this->someMock = $this->createMock(\stdClass::class);
    }

    public function testThis()
    {
        $this->assertSame('...', $this->someMock);
    }
}

It got crash:

1 test triggered 1 PHP warning:

1) /Users/samsonasik/www/rector-phpunit/rules/PHPUnit120/Rector/Class_/PropertyCreateMockToCreateStubRector.php:75
Attempt to read property "type" on null

Ref https://getrector.com/demo/805aa088-6c4d-4809-84e2-ccc2fd8e6fd1
Fixes rectorphp/rector#9774

@samsonasik
Copy link
Copy Markdown
Member Author

Fixed 🎉 /cc @gemal

@samsonasik
Copy link
Copy Markdown
Member Author

All green 🎉 @TomasVotruba let's merge 👍

@samsonasik samsonasik merged commit 0dbd58c into main Jun 2, 2026
8 checks passed
@samsonasik samsonasik deleted the prop-not-exists branch June 2, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

System error: "Attempt to assign property "type" on null"

1 participant