Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<?php

declare(strict_types=1);

namespace Rector\Tests\DeadCode\Rector\MethodCall\RemoveNullArgOnNullDefaultParamRector\Fixture;

/**
* @see https://3v4l.org/RCVaU#v8.3.9 vs https://3v4l.org/6DSlE#v8.3.9
*/
final class SkipWithUseOfFuncNumArgs
{
private $b = 1;

public function set($a, $b = null)
{
if (func_num_args() > 1) {
$this->b = $b;
}
}

public function get()
{
$this->set(1, null);
return $this->b;
}
}
6 changes: 6 additions & 0 deletions rules/DeadCode/NodeAnalyzer/CallLikeParamDefaultResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,14 @@
use PHPStan\Reflection\MethodReflection;
use PHPStan\Reflection\ParametersAcceptorSelector;
use PHPStan\Type\NullType;
use Rector\NodeAnalyzer\VariadicAnalyzer;
use Rector\Reflection\ReflectionResolver;

final readonly class CallLikeParamDefaultResolver
{
public function __construct(
private ReflectionResolver $reflectionResolver,
private VariadicAnalyzer $variadicAnalyzer,
) {
}

Expand All @@ -38,6 +40,10 @@ public function resolveNullPositions(MethodCall|StaticCall|New_|FuncCall $callLi
}
}

if ($this->variadicAnalyzer->hasVariadicParameters($callLike)) {
return [];
}

$nullPositions = [];

$extendedParametersAcceptor = ParametersAcceptorSelector::combineAcceptors($reflection->getVariants());
Expand Down
3 changes: 2 additions & 1 deletion src/NodeAnalyzer/VariadicAnalyzer.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\New_;
use PhpParser\Node\Expr\StaticCall;
use PHPStan\Reflection\FunctionReflection;
use PHPStan\Reflection\MethodReflection;
Expand All @@ -18,7 +19,7 @@ public function __construct(
) {
}

public function hasVariadicParameters(FuncCall | StaticCall | MethodCall $call): bool
public function hasVariadicParameters(FuncCall | StaticCall | MethodCall | New_ $call): bool
{
$functionLikeReflection = $this->reflectionResolver->resolveFunctionLikeReflectionFromCall($call);
if ($functionLikeReflection === null) {
Expand Down
Loading