Extract AutoloadFileParameterResolver from bin, add tests#8035
Merged
samsonasik merged 1 commit intoJun 11, 2026
Merged
Conversation
Follow-up to rectorphp#8034, which merged before its last revision: the parameter registration moves from inline bin code into a unit-testable class. Tests pin that every CLI spelling (--autoload-file path, --autoload-file=path, -a path) resolves to the same real path, that the parameter stays untouched without the flag, and that registering it changes FileHashComputer's configuration hash. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
|
@SanderMuller ok, I am merging it, but this PR and previous PR #8034 is not yet verifiable on our real projects, and I may need to verify which one which it cause a behaviour change, so we may revert these later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last revision of #8034 missed the merge by two minutes — this is it.
Moves the parameter registration from inline bin code into a small class, no behavior change, and adds tests: all three CLI spellings (
--autoload-file path,--autoload-file=path,-a path) resolve to the same value, no flag leaves the parameter untouched, and registering it changes the configuration hash.