Get/Upsert customer endpoints - #89
Open
Josh Moody (joshmoody24) wants to merge 1 commit into
Open
Conversation
Josh Moody (joshmoody24)
commented
Feb 5, 2026
Josh Moody (joshmoody24)
commented
Contributor
Josh Moody (joshmoody24)
changed the title
Comment on lines
+17
to
+20
| phoneNumber: | ||
| description: Customer phone number in E.164 format (e.g., +12345678900) | ||
| minLength: 1 | ||
| type: string |
Contributor
Author
There was a problem hiding this comment.
My biggest question is, should we include phoneNumber in the list of possible input identifiers, or just have email for now?
Allowing phoneNumber opens up the API to the can of worms that is customer merging. And since it's potentially shared, if someone just gives us a phoneNumber (no email) it would just find the first of potentially many customers to update.
Josh Moody (joshmoody24)
force-pushed
the
josh/upsert-customer
branch
from
February 5, 2026 01:47
54357de to
5e3bebc
Compare
Matt Meyers (mmeyers830)
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.