style: fix failing check-style#1671
Merged
Merged
Conversation
Contributor
Author
|
Not sure how we managed to merge something that broke the master branch? Or did an eslint update change styles out from under us? Either way, this should fix things 😄 |
hekike
approved these changes
Jun 5, 2018
Contributor
|
@retrohacker we have seen this earlier with prettier that's why I removed carrots from package.json from prettier related packages. |
Contributor
Author
|
Failing Node.js v10 tests, unrelated to this PR, merging. |
Contributor
Author
|
Actually looks like this might stomp on #1672 if you want to just fix the style issues with that PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like master's
make prepushfails with a style issue. This PR fixes that and unblocks #1668