Use configured time for job snoozes and retries#1332
Draft
pablobaldez wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config.Test.Timeis used when River evaluates whether scheduled jobsare eligible to run, but
JobSnoozeand the default retry policy derivedtheir next
scheduled_atvalues from the process wall clock. When aconfigured time generator differed from wall time, this mixed two
timelines in the same scheduling flow and could make snoozed or retried
jobs run too early or remain ineligible for much longer than intended.
Here, derive snooze timestamps from the executor's configured time and
initialize River's default retry policy from the same base service clock.
This also initializes the default fallback policy in producer and
rivertest.Workerexecution paths. Custom retry policies are unchanged,and zero-value use continues to fall back to wall time.
Regression coverage exercises both job snoozing and retrying through the
public client boundary with a configured time generator. Focused tests
and
make lintpass. The full localmake testrun encounters existingTestProducer_PollOnlytimeouts that reproduce on the unchanged basecommit.
Fixes #1322.