Rename a couple res/result variables to have more specific names - #309
Merged
Merged
Conversation
brandur
force-pushed
the
brandur-res-specific-names
branch
from
May 2, 2024 00:26
cde1ad0 to
d357e4f
Compare
A few small variable name changes that were on my TODO list: * Rename job list result variable names from `res` to a more specific `listRes`. This matches up better with the `insertRes` convention used in #292. * Rename `result` in job parameter functions to the more descriptive `paramsCopy`.
brandur
force-pushed
the
brandur-res-specific-names
branch
from
May 2, 2024 00:50
d357e4f to
62f7eb7
Compare
bgentry
approved these changes
May 2, 2024
Contributor
Author
|
Thx. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few small variable name changes that were on my TODO list:
Rename job list result variable names from
resto a more specificlistRes. This matches up better with theinsertResconvention usedin Have client insert functions return insert result instead of raw job row (breaking) #292.
Rename
resultin job parameter functions to the more descriptiveparamsCopy.