Skip to content

Fix river.JobStateAvailable reference in cmd/river/ #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandur merged 2 commits into from
Apr 23, 2024
Merged

Fix river.JobStateAvailable reference in cmd/river/ #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5317c9f
Fix `river.JobStateAvailable` reference in `cmd/river/`
dhermes Apr 22, 2024
308decd
Update godoc references to `river.JobState*`
dhermes Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1465,7 +1465,7 @@ type JobListResult struct {
// provided context is used for the underlying Postgres query and can be used to
// cancel the operation or apply a timeout.
//
// params := river.NewJobListParams().WithLimit(10).State(river.JobStateCompleted)
// params := river.NewJobListParams().WithLimit(10).State(rivertype.JobStateCompleted)

@dhermes dhermes Apr 22, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found these via git grep -n river.JobState

// jobRows, err := client.JobList(ctx, params)
// if err != nil {
// // handle error
Expand Down Expand Up @@ -1498,7 +1498,7 @@ func (c *Client[TTx]) JobList(ctx context.Context, params *JobListParams) (*JobL
// provided context is used for the underlying Postgres query and can be used to
// cancel the operation or apply a timeout.
//
// params := river.NewJobListParams().WithLimit(10).State(river.JobStateCompleted)
// params := river.NewJobListParams().WithLimit(10).State(rivertype.JobStateCompleted)
// jobRows, err := client.JobListTx(ctx, tx, params)
// if err != nil {
// // handle error
Expand Down
2 changes: 1 addition & 1 deletion cmd/river/riverbench/river_bench.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ func (b *Benchmarker[TTx]) Run(ctx context.Context) error {
return

case <-ticker.C:
numJobs, err := b.driver.GetExecutor().JobCountByState(ctx, river.JobStateAvailable)
numJobs, err := b.driver.GetExecutor().JobCountByState(ctx, rivertype.JobStateAvailable)
if err != nil {
b.logger.ErrorContext(ctx, "Error counting jobs", "err", err)
continue
Expand Down