Set periodic attribute in periodic job metadata - #728
Merged
Conversation
bgentry
force-pushed
the
bg-periodic-job-metadata
branch
2 times, most recently
from
January 23, 2025 04:48
878d197 to
f536c6e
Compare
This attribute makes periodic jobs easier to identify over regular jobs.
bgentry
force-pushed
the
bg-periodic-job-metadata
branch
from
January 23, 2025 04:49
f536c6e to
be20964
Compare
brandur
approved these changes
Jan 23, 2025
brandur
left a comment
brandur
left a comment
Contributor
There was a problem hiding this comment.
Nice! Yep, seems worthwhile.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor improvement coming out of #727 (reply in thread). Periodic jobs are currently indistinguishable from jobs inserted normally, which can make debugging more difficult. This PR changes the periodic job enqueuer to set a
"periodic": trueattribute on all periodic jobs' metadata to make them identifiable.