Group async and sync tests into separate test classes - #29
Merged
Conversation
Group async and sync tests into separate test classes like `TestClient` and `TestAsyncClient`. Along with organizing things more clearly, the major advantage of this is that we can localize fixtures to the specific classes where they're useful. So instead of `client` and `client_async`, we just have `client` in both both test classes. This is not only more clear, but greatly reduces errors because it's not possible to use the wrong fixture, and makes tests more copy/pastable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group async and sync tests into separate test classes like
TestClientand
TestAsyncClient. Along with organizing things more clearly, themajor advantage of this is that we can localize fixtures to the specific
classes where they're useful. So instead of
clientandclient_async,we just have
clientin both both test classes. This is not only moreclear, but greatly reduces errors because it's not possible to use the
wrong fixture, and makes tests more copy/pastable.