Externally useful attributes should be declared public and documented.

[pekkaklarck]

Old Selenium2Library has several attributes that are useful externally from custom libraries and extensions:

_run_on_failure_keyword
_speed_in_secs
_timeout_in_secs
_implicit_wait_in_secs
_current_browser()

We should indicate that using these externally is OK by removing the leading underscore. The current WebDriver instance should also be accessible as a normal attribute (i.e. without calling a method like current_browser()) and we should name the attribute webdriver to make it explicit what it actually is. I would also remove unnecessary _in_secs postfixes. In other words, I would like to have these attributes instead:

run_on_failure_keyword
speed
timeout
implicit_wait
webdriver

Renaming these attributes is obviously a backwards incompatible change. We should thus add propertys that enable the old functionality but emit deprecation warnings. These propertys can then be removed in 3.1 or later.

---

UPDATES:

1. We used browser attribute instead of webdriver until 3.0 RC 1.

2. In 3.0 RC 1 we added also methods find_element and find_elements directly to the library itself. These methods form the recommended public API to find elements for external tools.

[pekkaklarck]

This is mostly fixed if #884 is merged. The remaining decisions to make are:

• Should deprecated attributes be unit tested somehow? Shouldn't be too hard, but adding tests for features that are going to be removed pretty soon feels a bit like waste.

• What do to with _browsers?

[aaltat]

1. I think that it is waste too, lets not do unit test for those.
2. Is the cache for drivers. There already are public API to register driver, get the current driver and switch between drivers and close driver. With those API it might be better to leave it private.

[pekkaklarck]

If we aren't going to add more tests and we'll keep _browsers as-is, isn't this issue done?

[aaltat]

Yes it's. Closing