Fix setting cookie expiry date

[chenry35]

Hey,

I saw you deleted the optionnal argument expiry date on the keyword : add cookie.

Is there any way to add this option again? I want to add an expiry date on my cookie.

Thanks

[aaltat]

The expiry argument was there but as you can see from the code from below (from release 1.8.0), it was not used anywhere.

    def add_cookie(self,name, value, path=None, domain=None, secure=None,
            expiry=None):
        """Adds a cookie to your current session.
        "name" and "value" are required, "path", "domain" and "secure" are
        optional"""
        new_cookie = {'name'    : name,
                      'value'   : value}
        if path: new_cookie['path'] = path
        if domain: new_cookie['domain'] = domain
        #secure should be True or False so check explicitly for None
        if not secure is None: new_cookie['secure'] = secure
        self._current_browser().add_cookie(new_cookie)

I happy to review a PR which adds the argument and a logic which actually sets the expiry for the cookie.

[pekkaklarck]

As @aaltat commented, expiry was removed by #847 because it wasn't used. It would be a lot better to fix it instead. PR #930 looks so promising that I assign this issue to SL 3.0 rc 1 scope.

[pekkaklarck]

This issue requires a way to get the current cookie expiry time. PR #930 proposed introducing new Get Cookie Expiry keyword, but I'd rather add a keyword for getting all cookie information and added separate issue #932 about that.

[aaltat]

Done in #930