Skip to content

screenshots are overwritten only if filename is excplicitly given #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
orlof wants to merge 1 commit into from
Closed

screenshots are overwritten only if filename is excplicitly given #428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/Selenium2Library/keywords/_screenshot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,19 @@ def capture_page_screenshot(self, filename=None):
# Private

def _get_screenshot_paths(self, filename):
logdir = self._get_log_dir()

if not filename:
self._screenshot_index += 1
filename = 'selenium-screenshot-%d.png' % self._screenshot_index
while True:
# if filename is not specified, don't overwrite images
self._screenshot_index += 1
filename = 'selenium-screenshot-%d.png' % self._screenshot_index
path = os.path.join(logdir, filename)
if not os.path.exists(path):
break
else:
filename = filename.replace('/', os.sep)
logdir = self._get_log_dir()
path = os.path.join(logdir, filename)
path = os.path.join(logdir, filename)

link = robot.utils.get_link_path(path, logdir)
return path, link