Skip to content

Get Matching XPath Count - documentation isn't up-to-date#866

Closed
GLMeece wants to merge 1 commit into
robotframework:masterfrom
GLMeece:GetXPathCountAsInt
Closed

Get Matching XPath Count - documentation isn't up-to-date#866
GLMeece wants to merge 1 commit into
robotframework:masterfrom
GLMeece:GetXPathCountAsInt

Conversation

@GLMeece

@GLMeece GLMeece commented Aug 18, 2017

Copy link
Copy Markdown
Contributor

Ran the document generator; this keyword's documentation is now updated.

You made the code change I suggested awhile back, but the documentation hasn't been generated since. I think the user base would appreciate the update. I often "warn" people on the Slack channel to make sure they cast the return to an int, but as it turns out they can just add the parameter return_str=${False}.

Since "no code was harmed in the making of this Pull Request" it should be easy to merge it in. 🕶️

Ran the document generator; this keyword's documentation is now updated.
@aaltat

aaltat commented Aug 18, 2017

Copy link
Copy Markdown
Contributor

The public documentation is only updated when we make a release. But there is a good point and perhaps we should consider providing documentation in same manner as core framework provides the documents.

@aaltat

aaltat commented Aug 20, 2017

Copy link
Copy Markdown
Contributor

Because we are not going to update the documentation at this stage, I am closing the PR.

@aaltat aaltat closed this Aug 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants